| Message ID | 20210623030545.7627-1-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 9b54182ce23946674231bbe3ee22f89dfe274cab |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | drm: rcar-du: lvds: Don't set bridge driver_private field | expand |
Hi Laurent, On 23/06/2021 04:05, Laurent Pinchart wrote: > The drm_bridge.driver_private field is set but never used. Don't set it. Doesn't seem harmful to keep it though.. but if it's not needed.. It looks like we get the driver context structure through container_of with bridge_to_rcar_lvds(), as the bridge is embedded there so indeed it's not needed. Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c > index 70dbbe44bb23..5909173b26eb 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c > +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c > @@ -919,7 +919,6 @@ static int rcar_lvds_probe(struct platform_device *pdev) > if (ret < 0) > return ret; > > - lvds->bridge.driver_private = lvds; > lvds->bridge.funcs = &rcar_lvds_bridge_ops; > lvds->bridge.of_node = pdev->dev.of_node; > >
diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c index 70dbbe44bb23..5909173b26eb 100644 --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c @@ -919,7 +919,6 @@ static int rcar_lvds_probe(struct platform_device *pdev) if (ret < 0) return ret; - lvds->bridge.driver_private = lvds; lvds->bridge.funcs = &rcar_lvds_bridge_ops; lvds->bridge.of_node = pdev->dev.of_node;
The drm_bridge.driver_private field is set but never used. Don't set it. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 - 1 file changed, 1 deletion(-)