| Message ID | 20210630120425.606957-4-Nehal-Bakulchandra.shah@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | spi:amd:Support for new generation of AMD SOCs. | expand |
On Wed, Jun 30, 2021 at 05:34:25PM +0530, Nehal Bakulchandra Shah wrote: > Update the KConfig with dependency for ACPI as driver is only > supported for x86 platform. This fixes the compilation error > reported by kernel test robot. If one of the earlier patches in the series fails to build you need to fix that patch so you don't break bisection or cause people to spend time finding errors in the earlier patches you fix later. In any case this doesn't do what the commit log says, ACPI is supported on at least arm64 so if you genuinely need an x86 dependency ACPI isn't going to cut it and COMPILE_TEST means the driver will still be built on everything. I don't recall anything from 0day that looked like it was anything to do with dependencies though.
Hi Mark On 6/30/2021 6:17 PM, Mark Brown wrote: > On Wed, Jun 30, 2021 at 05:34:25PM +0530, Nehal Bakulchandra Shah wrote: > >> Update the KConfig with dependency for ACPI as driver is only >> supported for x86 platform. This fixes the compilation error >> reported by kernel test robot. > If one of the earlier patches in the series fails to build you need to > fix that patch so you don't break bisection or cause people to spend > time finding errors in the earlier patches you fix later. > > In any case this doesn't do what the commit log says, ACPI is supported > on at least arm64 so if you genuinely need an x86 dependency ACPI isn't > going to cut it and COMPILE_TEST means the driver will still be built on > everything. I don't recall anything from 0day that looked like it was > anything to do with dependencies though. so now should i RESEND this patch with suggested changes,i.e removing ACPI depedency change and removing COMPILE_TEST? Thanks Nehal
On Wed, Jun 30, 2021 at 08:14:12PM +0530, Shah, Nehal-bakulchandra wrote: > > everything. I don't recall anything from 0day that looked like it was > > anything to do with dependencies though. > so now should i RESEND this patch with suggested changes,i.e removing ACPI > depedency > change and removing COMPILE_TEST? No, you should fix the actual problem - like I say it looked like just a regular coding error, not something due to an actual dependency.
Hi Mark On 6/30/2021 6:17 PM, Mark Brown wrote: > On Wed, Jun 30, 2021 at 05:34:25PM +0530, Nehal Bakulchandra Shah wrote: > >> Update the KConfig with dependency for ACPI as driver is only >> supported for x86 platform. This fixes the compilation error >> reported by kernel test robot. > If one of the earlier patches in the series fails to build you need to > fix that patch so you don't break bisection or cause people to spend > time finding errors in the earlier patches you fix later. > > In any case this doesn't do what the commit log says, ACPI is supported > on at least arm64 so if you genuinely need an x86 dependency ACPI isn't > going to cut it and COMPILE_TEST means the driver will still be built on > everything. I don't recall anything from 0day that looked like it was > anything to do with dependencies though. Thanks for reviewing this patch series, however we have decided to drop this patch series and our partner (Cirrus) will send the new patch series with more finer changes. Regards Nehal Shah
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index e71a4c514f7b..532387929085 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -978,7 +978,7 @@ config SPI_ZYNQMP_GQSPI config SPI_AMD tristate "AMD SPI controller" - depends on SPI_MASTER || COMPILE_TEST + depends on (SPI_MASTER && ACPI) || COMPILE_TEST help Enables SPI controller driver for AMD SoC.