| Message ID | 20210630174308.31831-6-kabel@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dsa: mv88e6xxx: Topaz fixes | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | fail | 1 blamed authors not CCed: nikita.yoush@cogentembedded.com; 4 maintainers not CCed: olteanv@gmail.com f.fainelli@gmail.com linux@armlinux.org.uk nikita.yoush@cogentembedded.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 18 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Wed, Jun 30, 2021 at 07:43:07PM +0200, Marek Behún wrote: > Commit 0df952873636a ("mv88e6xxx: Add serdes Rx statistics") added > support for RX statistics on SerDes ports for Peridot. > > This same implementation is also valid for Topaz, but was not enabled > at the time. > > Signed-off-by: Marek Behún <kabel@kernel.org> > Fixes: 0df952873636a ("mv88e6xxx: Add serdes Rx statistics") Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Wed, 30 Jun 2021 19:43:07 +0200 Marek Behún <kabel@kernel.org> wrote: > Commit 0df952873636a ("mv88e6xxx: Add serdes Rx statistics") added > support for RX statistics on SerDes ports for Peridot. > > This same implementation is also valid for Topaz, but was not enabled > at the time. > > Signed-off-by: Marek Behún <kabel@kernel.org> > Fixes: 0df952873636a ("mv88e6xxx: Add serdes Rx statistics") I accidentally sent wrong version of this fix which won't work. There is another change needed which I applied to another branch while testing and then generated the patches from the branch where this change was missing. I am going to send v2 in a moment.
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 354ff0b84b7f..1e95a0facbd4 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3623,6 +3623,9 @@ static const struct mv88e6xxx_ops mv88e6141_ops = { .serdes_irq_enable = mv88e6390_serdes_irq_enable, .serdes_irq_status = mv88e6390_serdes_irq_status, .gpio_ops = &mv88e6352_gpio_ops, + .serdes_get_sset_count = mv88e6390_serdes_get_sset_count, + .serdes_get_strings = mv88e6390_serdes_get_strings, + .serdes_get_stats = mv88e6390_serdes_get_stats, .phylink_validate = mv88e6341_phylink_validate, }; @@ -4429,6 +4432,9 @@ static const struct mv88e6xxx_ops mv88e6341_ops = { .gpio_ops = &mv88e6352_gpio_ops, .avb_ops = &mv88e6390_avb_ops, .ptp_ops = &mv88e6352_ptp_ops, + .serdes_get_sset_count = mv88e6390_serdes_get_sset_count, + .serdes_get_strings = mv88e6390_serdes_get_strings, + .serdes_get_stats = mv88e6390_serdes_get_stats, .phylink_validate = mv88e6341_phylink_validate, };
Commit 0df952873636a ("mv88e6xxx: Add serdes Rx statistics") added support for RX statistics on SerDes ports for Peridot. This same implementation is also valid for Topaz, but was not enabled at the time. Signed-off-by: Marek Behún <kabel@kernel.org> Fixes: 0df952873636a ("mv88e6xxx: Add serdes Rx statistics") --- drivers/net/dsa/mv88e6xxx/chip.c | 6 ++++++ 1 file changed, 6 insertions(+)