| Message ID | 20210625133414.26760-1-jeremy.szu@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dfc2e8ae4066a95c7f9c2bb2dfa26651feaa6b83 |
| Headers | show |
| Series | ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook 830 G8 Notebook PC | expand |
On Fri, 25 Jun 2021 15:34:13 +0200, Jeremy Szu wrote: > > The HP EliteBook 830 G8 Notebook PC using ALC285 codec which using 0x04 to > control mute LED and 0x01 to control micmute LED. > Therefore, add a quirk to make it works. > > Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> Thanks, applied. Takashi
Hi Takashi, May I know where the tree containing this patch is? I didn't see this patch in git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git. On Sat, Jun 26, 2021 at 12:29 AM Takashi Iwai <tiwai@suse.de> wrote: > > On Fri, 25 Jun 2021 15:34:13 +0200, > Jeremy Szu wrote: > > > > The HP EliteBook 830 G8 Notebook PC using ALC285 codec which using 0x04 to > > control mute LED and 0x01 to control micmute LED. > > Therefore, add a quirk to make it works. > > > > Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> > > Thanks, applied. > > > Takashi
On Thu, 01 Jul 2021 08:23:42 +0200, Jeremy Szu wrote: > > Hi Takashi, > > May I know where the tree containing this patch is? > I didn't see this patch in > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git. My bad, I forgot to push out the tree before entering my vacation. Now it's out. Takashi > > > On Sat, Jun 26, 2021 at 12:29 AM Takashi Iwai <tiwai@suse.de> wrote: > > > > On Fri, 25 Jun 2021 15:34:13 +0200, > > Jeremy Szu wrote: > > > > > > The HP EliteBook 830 G8 Notebook PC using ALC285 codec which using 0x04 to > > > control mute LED and 0x01 to control micmute LED. > > > Therefore, add a quirk to make it works. > > > > > > Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> > > > > Thanks, applied. > > > > > > Takashi > > > > -- > Sincerely, > Jeremy Su >
Hi Takashi, No problem, many thanks! On Thu, Jul 1, 2021 at 2:33 PM Takashi Iwai <tiwai@suse.de> wrote: > > On Thu, 01 Jul 2021 08:23:42 +0200, > Jeremy Szu wrote: > > > > Hi Takashi, > > > > May I know where the tree containing this patch is? > > I didn't see this patch in > > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git. > > My bad, I forgot to push out the tree before entering my vacation. > Now it's out. > > > Takashi > > > > > > > On Sat, Jun 26, 2021 at 12:29 AM Takashi Iwai <tiwai@suse.de> wrote: > > > > > > On Fri, 25 Jun 2021 15:34:13 +0200, > > > Jeremy Szu wrote: > > > > > > > > The HP EliteBook 830 G8 Notebook PC using ALC285 codec which using 0x04 to > > > > control mute LED and 0x01 to control micmute LED. > > > > Therefore, add a quirk to make it works. > > > > > > > > Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> > > > > > > Thanks, applied. > > > > > > > > > Takashi > > > > > > > > -- > > Sincerely, > > Jeremy Su > >
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 49f4cac8b05e..1ea9853bbb09 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8366,6 +8366,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), + SND_PCI_QUIRK(0x103c, 0x880d, "HP EliteBook 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8847, "HP EliteBook x360 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x884b, "HP EliteBook 840 Aero G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
The HP EliteBook 830 G8 Notebook PC using ALC285 codec which using 0x04 to control mute LED and 0x01 to control micmute LED. Therefore, add a quirk to make it works. Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)