| Message ID | CD536CB4-9110-47F4-8357-F9F2C867A532@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Help with patch | expand |
On Mon, 5 Jul 2021 at 14:29, Programmingkid <programmingkidx@gmail.com> wrote: > > Hi, I made a patch that adds an icon to QEMU on Mac OS. Who should I send this patch to? > > > From 45650a7f52deb8c2c436d71a3fcf5326287c2e05 Mon Sep 17 00:00:00 2001 > From: John Arbuckle <programmingkidx@gmail.com> > Date: Tue, 2 Feb 2021 08:35:43 -0500 > Subject: [PATCH] Set icon for QEMU binary on Mac OS > > Before switching the build system over to Meson, an icon was > added to the QEMU binary on Mac OS. This patch adds back that > feature. > > Signed-off-by: John Arbuckle <programmingkidx@gmail.com> > --- > meson.build | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/meson.build b/meson.build > index f00b7754fd..7f534f4e75 100644 > --- a/meson.build > +++ b/meson.build > @@ -2183,6 +2183,26 @@ foreach target : target_dirs > link_args: link_args, > gui_app: exe['gui']) > > +# set QEMU's icon on Mac OS > +if targetos == 'darwin' > + newiconpart1 = custom_target('Icon for ' + exe_name + ' - part 1', > + depends : emulator, > + input : emulator, > + output : 'new icon for ' + exe_name + ' - 1', > + command : ['Rez', '-append', > + meson.source_root() + '/pc-bios/qemu.rsrc', '-o', > + meson.current_build_dir() / exe['name']], > + build_by_default : true) > + > + custom_target('Icon for ' + exe_name + ' - part 2', > + depends : newiconpart1, > + input : emulator, > + output : 'new icon for ' + exe_name + ' - 2', > + command : ['SetFile', '-a', 'C', > + meson.current_build_dir() / exe['name']], > + build_by_default : true) > +endif > + > if exe_sign > emulators += {exe['name'] : custom_target(exe['name'], > install: true, meson.build stuff is Paolo's domain. thanks -- PMM
diff --git a/meson.build b/meson.build index f00b7754fd..7f534f4e75 100644 --- a/meson.build +++ b/meson.build @@ -2183,6 +2183,26 @@ foreach target : target_dirs link_args: link_args, gui_app: exe['gui']) +# set QEMU's icon on Mac OS +if targetos == 'darwin' + newiconpart1 = custom_target('Icon for ' + exe_name + ' - part 1', + depends : emulator, + input : emulator, + output : 'new icon for ' + exe_name + ' - 1', + command : ['Rez', '-append', + meson.source_root() + '/pc-bios/qemu.rsrc', '-o', + meson.current_build_dir() / exe['name']], + build_by_default : true) + + custom_target('Icon for ' + exe_name + ' - part 2', + depends : newiconpart1, + input : emulator, + output : 'new icon for ' + exe_name + ' - 2', + command : ['SetFile', '-a', 'C', + meson.current_build_dir() / exe['name']], + build_by_default : true) +endif + if exe_sign emulators += {exe['name'] : custom_target(exe['name'], install: true,