| Message ID | 20210705053944.885828-1-hch@lst.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm: fix the try_to_unmap prototype for !CONFIG_MMU | expand |
On Sun, Jul 4, 2021 at 10:40 PM Christoph Hellwig <hch@lst.de> wrote: > > Adjust the nommu stub of try_to_unmap to match the changed protype > for the full version. Turn it into an inline instead of a macro to > generally improve the type checking. Thanks for catching this. Reviewed-by: Yang Shi <shy828301@gmail.com> > > Fixes: 1fb08ac63bee ("mm: rmap: make try_to_unmap() void function") > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > include/linux/rmap.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/linux/rmap.h b/include/linux/rmap.h > index 83fb86133fe1..c976cc6de257 100644 > --- a/include/linux/rmap.h > +++ b/include/linux/rmap.h > @@ -291,7 +291,9 @@ static inline int page_referenced(struct page *page, int is_locked, > return 0; > } > > -#define try_to_unmap(page, refs) false > +static inline void try_to_unmap(struct page *page, enum ttu_flags flags) > +{ > +} > > static inline int page_mkclean(struct page *page) > { > -- > 2.30.2 > >
diff --git a/include/linux/rmap.h b/include/linux/rmap.h index 83fb86133fe1..c976cc6de257 100644 --- a/include/linux/rmap.h +++ b/include/linux/rmap.h @@ -291,7 +291,9 @@ static inline int page_referenced(struct page *page, int is_locked, return 0; } -#define try_to_unmap(page, refs) false +static inline void try_to_unmap(struct page *page, enum ttu_flags flags) +{ +} static inline int page_mkclean(struct page *page) {
Adjust the nommu stub of try_to_unmap to match the changed protype for the full version. Turn it into an inline instead of a macro to generally improve the type checking. Fixes: 1fb08ac63bee ("mm: rmap: make try_to_unmap() void function") Signed-off-by: Christoph Hellwig <hch@lst.de> --- include/linux/rmap.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)