| Message ID | 20210708102549.27821-1-vandita.kulkarni@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Set BPP in the kernel | expand |
> -----Original Message----- > From: Kulkarni, Vandita <vandita.kulkarni@intel.com> > Sent: Thursday, July 8, 2021 3:56 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani <jani.nikula@intel.com>; Kulkarni, Vandita > <vandita.kulkarni@intel.com> > Subject: [v7 0/3] Set BPP in the kernel > > This series adds debugfs entry to force dsc bpp to ceratin valid test value, for > validation needs. > This series has been tested locally. > With the introduction of i915_dsc_bpp debugfs the expectation is that > whenever there is force_dsc_en set, force_dsc_bpp should have a valid > value for that format which is between bpp to bpp-1. Correction : *bpc to bpp-1 > > This makes the older test kms_dp_dsc --basic fail as in that case > force_dsc_bpp would be 0 and is not a valid value. > > Have tested with local changes on the same. > The series https://patchwork.freedesktop.org/series/91772/ > have the base patches and would need some work on the debugfs name > change, giving default value for force_dsc_bpp in case of basic-dsc-enable > test cases, clearing up of the force_dsc_bpp value while exiting the test. > Which will be floated shortly. > > Have added minor fix on the feci debugfs interface. > If further changes are needed on the same will float them in a different > series. > > Patnana Venkata Sai (1): > drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP > enable > > Vandita Kulkarni (2): > drm/i915/display: Add write permissions for fec support > drm/i915/display/dsc: Force dsc BPP > > .../drm/i915/display/intel_display_debugfs.c | 78 ++++++++++++++++++- > .../drm/i915/display/intel_display_types.h | 1 + > drivers/gpu/drm/i915/display/intel_dp.c | 17 ++++ > 3 files changed, 94 insertions(+), 2 deletions(-) > > -- > 2.32.0
> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of > Kulkarni, Vandita > Sent: Thursday, July 8, 2021 3:59 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani <jani.nikula@intel.com> > Subject: Re: [Intel-gfx] [v7 0/3] Set BPP in the kernel > > > -----Original Message----- > > From: Kulkarni, Vandita <vandita.kulkarni@intel.com> > > Sent: Thursday, July 8, 2021 3:56 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Nikula, Jani <jani.nikula@intel.com>; Kulkarni, Vandita > > <vandita.kulkarni@intel.com> > > Subject: [v7 0/3] Set BPP in the kernel > > > > This series adds debugfs entry to force dsc bpp to ceratin valid test > > value, for validation needs. > > This series has been tested locally. > > With the introduction of i915_dsc_bpp debugfs the expectation is that > > whenever there is force_dsc_en set, force_dsc_bpp should have a valid > > value for that format which is between bpp to bpp-1. > Correction : *bpc to bpp-1 > > > > This makes the older test kms_dp_dsc --basic fail as in that case > > force_dsc_bpp would be 0 and is not a valid value. The latest v2 patch fixes this, and if only force_dsc_en is set then default calculated dsc_bpp would be assigned. (Jani) Also, if the test sends invalid value, the driver will set the default value.( Jani) The test app for testing force_dsc_en - basic dsc enable tests would remain as is. Thanks, Vandita > > > > Have tested with local changes on the same. > > The series https://patchwork.freedesktop.org/series/91772/ > > have the base patches and would need some work on the debugfs name > > change, giving default value for force_dsc_bpp in case of > > basic-dsc-enable test cases, clearing up of the force_dsc_bpp value while > exiting the test. > > Which will be floated shortly. > > > > Have added minor fix on the feci debugfs interface. > > If further changes are needed on the same will float them in a > > different series. > > > > Patnana Venkata Sai (1): > > drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP > > enable > > > > Vandita Kulkarni (2): > > drm/i915/display: Add write permissions for fec support > > drm/i915/display/dsc: Force dsc BPP > > > > .../drm/i915/display/intel_display_debugfs.c | 78 ++++++++++++++++++- > > .../drm/i915/display/intel_display_types.h | 1 + > > drivers/gpu/drm/i915/display/intel_dp.c | 17 ++++ > > 3 files changed, 94 insertions(+), 2 deletions(-) > > > > -- > > 2.32.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
This series add debugfs entry to force dsc bpp to ceratin valid test value, for validation needs. This series has been tested locally. With the introduction of i915_dsc_bpp debugfs the expectation is that whenever there is force_dsc_en set, force_dsc_bpp should have a valid value for that format which is between bpp to bpp-1. This makes the older test kms_dp_dsc --basic fail as in that case force_dsc_bpp would be 0 and is not a valid value. Have tested with local changes on the same. The series https://patchwork.freedesktop.org/series/91772/ have the base patches and would need some work on the debugfs name change, giving default value for force_dsc_bpp in case of basic-dsc-enable test cases, clearing up of the force_dsc_bpp value while exiting the test. Which will be floated shortly. Have added minor fix on the feci debugfs interface. If further changes are needed on the same will float them in a different series. Patnana Venkata Sai (1): drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable Vandita Kulkarni (2): drm/i915/display: Add write permissions for fec support drm/i915/display/dsc: Force dsc BPP .../drm/i915/display/intel_display_debugfs.c | 78 ++++++++++++++++++- .../drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 17 ++++ 3 files changed, 94 insertions(+), 2 deletions(-)