| Message ID | 20210707115524.2242151-4-agruenba@redhat.com (mailing list archive) |
|---|---|
| State | Deferred, archived |
| Headers | show |
| Series | iomap: small block problems | expand |
On Wed, Jul 07, 2021 at 01:55:24PM +0200, Andreas Gruenbacher wrote: > Now that we create those objects in iomap_writepage_map when needed, > there's no need to pre-create them in iomap_page_mkwrite_actor anymore. > > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org> Thanks for sticking with this. It looks like a nice cleanup now rather than "argh, a bug, burn it with fire".
On Wed, Jul 07, 2021 at 01:55:24PM +0200, Andreas Gruenbacher wrote: > Now that we create those objects in iomap_writepage_map when needed, > there's no need to pre-create them in iomap_page_mkwrite_actor anymore. > > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> I'd like to stage this series as a bugfix branch against -rc1 next week, if there are no other objections? Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > fs/iomap/buffered-io.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index 6330dabc451e..9f45050b61dd 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -999,7 +999,6 @@ iomap_page_mkwrite_actor(struct inode *inode, loff_t pos, loff_t length, > block_commit_write(page, 0, length); > } else { > WARN_ON_ONCE(!PageUptodate(page)); > - iomap_page_create(inode, page); > set_page_dirty(page); > } > > -- > 2.26.3 >
On Wed, Jul 07, 2021 at 01:55:24PM +0200, Andreas Gruenbacher wrote: > Now that we create those objects in iomap_writepage_map when needed, > there's no need to pre-create them in iomap_page_mkwrite_actor anymore. > > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
On Fri, Jul 9, 2021 at 6:29 AM Darrick J. Wong <djwong@kernel.org> wrote: > On Wed, Jul 07, 2021 at 01:55:24PM +0200, Andreas Gruenbacher wrote: > > Now that we create those objects in iomap_writepage_map when needed, > > there's no need to pre-create them in iomap_page_mkwrite_actor anymore. > > > > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> > > I'd like to stage this series as a bugfix branch against -rc1 next week, > if there are no other objections? Yes, that would help a lot, thanks. Andreas
diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index 6330dabc451e..9f45050b61dd 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c @@ -999,7 +999,6 @@ iomap_page_mkwrite_actor(struct inode *inode, loff_t pos, loff_t length, block_commit_write(page, 0, length); } else { WARN_ON_ONCE(!PageUptodate(page)); - iomap_page_create(inode, page); set_page_dirty(page); }
Now that we create those objects in iomap_writepage_map when needed, there's no need to pre-create them in iomap_page_mkwrite_actor anymore. Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> --- fs/iomap/buffered-io.c | 1 - 1 file changed, 1 deletion(-)