| Message ID | 20210709081116.4170288-1-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dim/drm-misc: Add rule to not push patches with issues | expand |
Am 09.07.21 um 10:11 schrieb Daniel Vetter: > We kinda left this out, and I like the wording from the drm-intel > side, so add that. Motivated by a discussion with Christian. > > Cc: Christian König <christian.koenig@amd.com> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Maxime Ripard <mripard@kernel.org> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Reviewed-by: Christian König <christian.koenig@amd.com> > --- > committer-drm-misc.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/committer-drm-misc.rst b/committer-drm-misc.rst > index 9497a5d26a9d..110ca8b0525e 100644 > --- a/committer-drm-misc.rst > +++ b/committer-drm-misc.rst > @@ -21,6 +21,9 @@ Merge Criteria > > Right now the only hard merge criteria are: > > +* There must not be open issues or unresolved or conflicting feedback from > + anyone. Clear them up first. Defer to maintainers as needed. > + > * Patch is properly reviewed or at least Ack, i.e. don't just push your own > stuff directly. This rule holds even more for bugfix patches - it would be > embarrassing if the bugfix contains a small gotcha that review would have
On Fri, Jul 09, 2021 at 10:11:16AM +0200, Daniel Vetter wrote: > We kinda left this out, and I like the wording from the drm-intel > side, so add that. Motivated by a discussion with Christian. > > Cc: Christian König <christian.koenig@amd.com> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Maxime Ripard <mripard@kernel.org> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Acked-by: Maxime Ripard <maxime@cerno.tech> Thanks! Maxime
Am 09.07.21 um 10:11 schrieb Daniel Vetter: > We kinda left this out, and I like the wording from the drm-intel > side, so add that. Motivated by a discussion with Christian. I always thought this goes without saying. > > Cc: Christian König <christian.koenig@amd.com> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Maxime Ripard <mripard@kernel.org> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > committer-drm-misc.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/committer-drm-misc.rst b/committer-drm-misc.rst > index 9497a5d26a9d..110ca8b0525e 100644 > --- a/committer-drm-misc.rst > +++ b/committer-drm-misc.rst > @@ -21,6 +21,9 @@ Merge Criteria > > Right now the only hard merge criteria are: > > +* There must not be open issues or unresolved or conflicting feedback from > + anyone. Clear them up first. Defer to maintainers as needed. > + > * Patch is properly reviewed or at least Ack, i.e. don't just push your own > stuff directly. This rule holds even more for bugfix patches - it would be > embarrassing if the bugfix contains a small gotcha that review would have >
On Fri, Jul 9, 2021 at 10:11 AM Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > We kinda left this out, and I like the wording from the drm-intel > side, so add that. Motivated by a discussion with Christian. > > Cc: Christian König <christian.koenig@amd.com> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Maxime Ripard <mripard@kernel.org> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Pushed, thanks for all the r-b/acks. -Daniel > --- > committer-drm-misc.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/committer-drm-misc.rst b/committer-drm-misc.rst > index 9497a5d26a9d..110ca8b0525e 100644 > --- a/committer-drm-misc.rst > +++ b/committer-drm-misc.rst > @@ -21,6 +21,9 @@ Merge Criteria > > Right now the only hard merge criteria are: > > +* There must not be open issues or unresolved or conflicting feedback from > + anyone. Clear them up first. Defer to maintainers as needed. > + > * Patch is properly reviewed or at least Ack, i.e. don't just push your own > stuff directly. This rule holds even more for bugfix patches - it would be > embarrassing if the bugfix contains a small gotcha that review would have > -- > 2.32.0 >
diff --git a/committer-drm-misc.rst b/committer-drm-misc.rst index 9497a5d26a9d..110ca8b0525e 100644 --- a/committer-drm-misc.rst +++ b/committer-drm-misc.rst @@ -21,6 +21,9 @@ Merge Criteria Right now the only hard merge criteria are: +* There must not be open issues or unresolved or conflicting feedback from + anyone. Clear them up first. Defer to maintainers as needed. + * Patch is properly reviewed or at least Ack, i.e. don't just push your own stuff directly. This rule holds even more for bugfix patches - it would be embarrassing if the bugfix contains a small gotcha that review would have
We kinda left this out, and I like the wording from the drm-intel side, so add that. Motivated by a discussion with Christian. Cc: Christian König <christian.koenig@amd.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <mripard@kernel.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- committer-drm-misc.rst | 3 +++ 1 file changed, 3 insertions(+)