| Message ID | 20210714174051.28164-6-crosa@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | virtio-gpu acceptance test: use current device name | expand |
On Wed, Jul 14, 2021 at 2:41 PM Cleber Rosa <crosa@redhat.com> wrote: > > Since 49afbca3b, the use of an optional virgl renderer is not > available anymore, and since b36eb8860f, the way to choose a GL based > rendered is to use the "virtio-vga-gl" device. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/acceptance/virtio-gpu.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Willian Rampazzo <willianr@redhat.com>
On Wed, Jul 14, 2021 at 9:47 PM Cleber Rosa <crosa@redhat.com> wrote: > Since 49afbca3b, the use of an optional virgl renderer is not > available anymore, and since b36eb8860f, the way to choose a GL based > rendered is to use the "virtio-vga-gl" device. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> --- > tests/acceptance/virtio-gpu.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/acceptance/virtio-gpu.py > b/tests/acceptance/virtio-gpu.py > index fbde278705..0f84affe82 100644 > --- a/tests/acceptance/virtio-gpu.py > +++ b/tests/acceptance/virtio-gpu.py > @@ -56,7 +56,7 @@ def wait_for_console_pattern(self, success_message, > vm=None): > > def test_virtio_vga_virgl(self): > """ > - :avocado: tags=device:virtio-vga > + :avocado: tags=device:virtio-vga-gl > """ > # FIXME: should check presence of virtio, virgl etc > self.require_accelerator('kvm') > @@ -67,7 +67,7 @@ def test_virtio_vga_virgl(self): > self.vm.set_console() > self.vm.add_args("-m", "2G") > self.vm.add_args("-machine", "pc,accel=kvm") > - self.vm.add_args("-device", "virtio-vga,virgl=on") > + self.vm.add_args("-device", "virtio-vga-gl") > self.vm.add_args("-display", "egl-headless") > self.vm.add_args( > "-kernel", > -- > 2.31.1 > > >
On Wed, Jul 14, 2021 at 01:40:50PM -0400, Cleber Rosa wrote: > Since 49afbca3b, the use of an optional virgl renderer is not > available anymore, and since b36eb8860f, the way to choose a GL based > rendered is to use the "virtio-vga-gl" device. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/acceptance/virtio-gpu.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/acceptance/virtio-gpu.py b/tests/acceptance/virtio-gpu.py > index fbde278705..0f84affe82 100644 > --- a/tests/acceptance/virtio-gpu.py > +++ b/tests/acceptance/virtio-gpu.py > @@ -56,7 +56,7 @@ def wait_for_console_pattern(self, success_message, vm=None): > > def test_virtio_vga_virgl(self): > """ > - :avocado: tags=device:virtio-vga > + :avocado: tags=device:virtio-vga-gl > """ > # FIXME: should check presence of virtio, virgl etc > self.require_accelerator('kvm') > @@ -67,7 +67,7 @@ def test_virtio_vga_virgl(self): > self.vm.set_console() > self.vm.add_args("-m", "2G") > self.vm.add_args("-machine", "pc,accel=kvm") > - self.vm.add_args("-device", "virtio-vga,virgl=on") > + self.vm.add_args("-device", "virtio-vga-gl") > self.vm.add_args("-display", "egl-headless") > self.vm.add_args( > "-kernel", Reviewed-by: Gerd Hoffmann <kraxel@redhat.com> Side note: virgl=on isn't guaranteed to be present on old qemu versions, it is only there on --enable-virglrenderer builds. For upstream/master this is fine, but in case you want your test cases work on older qemu versions too you need to check that ... take care, Gerd
diff --git a/tests/acceptance/virtio-gpu.py b/tests/acceptance/virtio-gpu.py index fbde278705..0f84affe82 100644 --- a/tests/acceptance/virtio-gpu.py +++ b/tests/acceptance/virtio-gpu.py @@ -56,7 +56,7 @@ def wait_for_console_pattern(self, success_message, vm=None): def test_virtio_vga_virgl(self): """ - :avocado: tags=device:virtio-vga + :avocado: tags=device:virtio-vga-gl """ # FIXME: should check presence of virtio, virgl etc self.require_accelerator('kvm') @@ -67,7 +67,7 @@ def test_virtio_vga_virgl(self): self.vm.set_console() self.vm.add_args("-m", "2G") self.vm.add_args("-machine", "pc,accel=kvm") - self.vm.add_args("-device", "virtio-vga,virgl=on") + self.vm.add_args("-device", "virtio-vga-gl") self.vm.add_args("-display", "egl-headless") self.vm.add_args( "-kernel",
Since 49afbca3b, the use of an optional virgl renderer is not available anymore, and since b36eb8860f, the way to choose a GL based rendered is to use the "virtio-vga-gl" device. Signed-off-by: Cleber Rosa <crosa@redhat.com> --- tests/acceptance/virtio-gpu.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)