| Message ID | 596ed544412bb45581e9fe42cc519ec5a29ce13b.1626256348.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [resend] soc: rockchip: ROCKCHIP_GRF should not default to y, unconditionally | expand |
Hi Geert, Am Mittwoch, 14. Juli 2021, 11:53:15 CEST schrieb Geert Uytterhoeven: > Merely enabling CONFIG_COMPILE_TEST should not enable additional code. > To fix this, restrict the automatic enabling of ROCKCHIP_GRF to > ARCH_ROCKCHIP, and ask the user in case of compile-testing. > > Fixes: 4c58063d4258f6be ("soc: rockchip: add driver handling grf setup") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> I had the original patch picked already, just not pushed yet. So hopefully nothing changed between the sends. Heiko > --- > drivers/soc/rockchip/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/rockchip/Kconfig b/drivers/soc/rockchip/Kconfig > index 2c13bf4dd5dbee76..25eb2c1e31bb2a08 100644 > --- a/drivers/soc/rockchip/Kconfig > +++ b/drivers/soc/rockchip/Kconfig > @@ -6,8 +6,8 @@ if ARCH_ROCKCHIP || COMPILE_TEST > # > > config ROCKCHIP_GRF > - bool > - default y > + bool "Rockchip General Register Files support" if COMPILE_TEST > + default y if ARCH_ROCKCHIP > help > The General Register Files are a central component providing > special additional settings registers for a lot of soc-components. >
diff --git a/drivers/soc/rockchip/Kconfig b/drivers/soc/rockchip/Kconfig index 2c13bf4dd5dbee76..25eb2c1e31bb2a08 100644 --- a/drivers/soc/rockchip/Kconfig +++ b/drivers/soc/rockchip/Kconfig @@ -6,8 +6,8 @@ if ARCH_ROCKCHIP || COMPILE_TEST # config ROCKCHIP_GRF - bool - default y + bool "Rockchip General Register Files support" if COMPILE_TEST + default y if ARCH_ROCKCHIP help The General Register Files are a central component providing special additional settings registers for a lot of soc-components.
Merely enabling CONFIG_COMPILE_TEST should not enable additional code. To fix this, restrict the automatic enabling of ROCKCHIP_GRF to ARCH_ROCKCHIP, and ask the user in case of compile-testing. Fixes: 4c58063d4258f6be ("soc: rockchip: add driver handling grf setup") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/soc/rockchip/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)