| Message ID | cover.1624028025.git.charante@codeaurora.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | mm: compaction: proactive compaction trigger by user | expand |
A gentle ping to have your valuable comments. Thanks, Charan On 6/18/2021 8:48 PM, Charan Teja Reddy wrote: > These patches support triggering of proactive compaction by user on write > to the /proc/sys/vm/compaction_proactiveness. > > Changes in V4: > -- Changed the code as the 'proactive_defer' counter is removed. > -- No changes in the logic of triggering the proactive compaction. > -- Removed the 'proactive_defer' counter. > > Changes in V3: > -- Fixed review comments from Vlastimil and others. > -- Fixed wake up logic when compaction_proactiveness is zero. > -- https://lore.kernel.org/patchwork/patch/1438211/ > > Changes in V2: > -- remove /proc/../proactive_compact_memory interface trigger for proactive compaction > -- Intention is same that add a way to trigger proactive compaction by user. > -- https://lore.kernel.org/patchwork/patch/1431283/ > > Changes in V1: > -- Created the new /proc/sys/vm/proactive_compact_memory in > interface to trigger proactive compaction from user > -- https://lore.kernel.org/lkml/1619098678-8501-1-git-send-email-charante@codeaurora.org/ > > > Charan Teja Reddy (3): > mm: compaction: optimize proactive compaction deferrals > mm: compaction: support triggering of proactive compaction by user > mm: compaction: fix wakeup logic of proactive compaction > > Documentation/admin-guide/sysctl/vm.rst | 3 +- > include/linux/compaction.h | 2 ++ > include/linux/mmzone.h | 1 + > kernel/sysctl.c | 2 +- > mm/compaction.c | 61 +++++++++++++++++++++++++++------ > 5 files changed, 56 insertions(+), 13 deletions(-) >
On Sat, 3 Jul 2021 15:52:10 +0530 Charan Teja Kalla <charante@codeaurora.org> wrote:
> A gentle ping to have your valuable comments.
Can we please have a resend?
The series has two fixes against the current code. Please separate
that work out from the new feature. So a 2-patch series to fix the bugs
followed by a single patch to add your new feature.
Thanks Andrew for the reply!! On 7/16/2021 9:57 AM, Andrew Morton wrote: > On Sat, 3 Jul 2021 15:52:10 +0530 Charan Teja Kalla <charante@codeaurora.org> wrote: > >> A gentle ping to have your valuable comments. > > Can we please have a resend? > > The series has two fixes against the current code. Please separate > that work out from the new feature. So a 2-patch series to fix the bugs > followed by a single patch to add your new feature. https://lore.kernel.org/patchwork/patch/1448789/ -- Can go as a separate bug fix. https://lore.kernel.org/patchwork/patch/1448793/ -- is the second bug fix which is tightly coupled with the feature of explicitly waking of kcompactd on the event of change in compaction proactiveness, when it is sleeping with MAX_SCHEDULE_TIMEOUT. So, will make the changes with 1 patch bug fix and 2nd patch feature where the second bug fix also clubbed. I hope this is fine. > >
These patches support triggering of proactive compaction by user on write to the /proc/sys/vm/compaction_proactiveness. Changes in V4: -- Changed the code as the 'proactive_defer' counter is removed. -- No changes in the logic of triggering the proactive compaction. -- Removed the 'proactive_defer' counter. Changes in V3: -- Fixed review comments from Vlastimil and others. -- Fixed wake up logic when compaction_proactiveness is zero. -- https://lore.kernel.org/patchwork/patch/1438211/ Changes in V2: -- remove /proc/../proactive_compact_memory interface trigger for proactive compaction -- Intention is same that add a way to trigger proactive compaction by user. -- https://lore.kernel.org/patchwork/patch/1431283/ Changes in V1: -- Created the new /proc/sys/vm/proactive_compact_memory in interface to trigger proactive compaction from user -- https://lore.kernel.org/lkml/1619098678-8501-1-git-send-email-charante@codeaurora.org/ Charan Teja Reddy (3): mm: compaction: optimize proactive compaction deferrals mm: compaction: support triggering of proactive compaction by user mm: compaction: fix wakeup logic of proactive compaction Documentation/admin-guide/sysctl/vm.rst | 3 +- include/linux/compaction.h | 2 ++ include/linux/mmzone.h | 1 + kernel/sysctl.c | 2 +- mm/compaction.c | 61 +++++++++++++++++++++++++++------ 5 files changed, 56 insertions(+), 13 deletions(-)