| Message ID | 20210627163244.1090296-5-jic23@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dt-bindings: iio: dac: Add most missing binding documents. | expand |
On Sun, Jun 27, 2021 at 05:32:33PM +0100, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > A simple binding for this particular DAC familly. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Lars-Peter Clausen <lars@metafoo.de> > --- > .../bindings/iio/dac/adi,ad5380.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5380.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5380.yaml > new file mode 100644 > index 000000000000..d599b418a020 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5380.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/dac/adi,ad5380.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices AD5380 and similar DACs > + > +maintainers: > + - Lars-Peter Clausen <lars@metafoo.de> > + - Jonathan Cameron <jic23@kernel.org> > + > +description: | > + DAC devices supporting both SPI and I2C interfaces. > +properties: > + compatible: > + enum: > + - adi,ad5380-3 > + - adi,ad5380-5 > + - adi,ad5381-3 > + - adi,ad5381-5 > + - adi,ad5382-3 > + - adi,ad5382-5 > + - adi,ad5383-3 > + - adi,ad5383-5 > + - adi,ad5384-3 > + - adi,ad5384-5 > + - adi,ad5390-3 > + - adi,ad5390-5 > + - adi,ad5391-3 > + - adi,ad5391-5 > + - adi,ad5392-3 > + - adi,ad5392-5 You could do this: pattern: '^adi,ad53(8[0-4]|9[0-2])-[35]$' Either way, Reviewed-by: Rob Herring <robh@kernel.org>
On Wed, 14 Jul 2021 09:54:21 -0600 Rob Herring <robh@kernel.org> wrote: > On Sun, Jun 27, 2021 at 05:32:33PM +0100, Jonathan Cameron wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > A simple binding for this particular DAC familly. > > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Cc: Lars-Peter Clausen <lars@metafoo.de> > > --- > > .../bindings/iio/dac/adi,ad5380.yaml | 70 +++++++++++++++++++ > > 1 file changed, 70 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5380.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5380.yaml > > new file mode 100644 > > index 000000000000..d599b418a020 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5380.yaml > > @@ -0,0 +1,70 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/dac/adi,ad5380.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Analog Devices AD5380 and similar DACs > > + > > +maintainers: > > + - Lars-Peter Clausen <lars@metafoo.de> > > + - Jonathan Cameron <jic23@kernel.org> > > + > > +description: | > > + DAC devices supporting both SPI and I2C interfaces. > > +properties: > > + compatible: > > + enum: > > + - adi,ad5380-3 > > + - adi,ad5380-5 > > + - adi,ad5381-3 > > + - adi,ad5381-5 > > + - adi,ad5382-3 > > + - adi,ad5382-5 > > + - adi,ad5383-3 > > + - adi,ad5383-5 > > + - adi,ad5384-3 > > + - adi,ad5384-5 > > + - adi,ad5390-3 > > + - adi,ad5390-5 > > + - adi,ad5391-3 > > + - adi,ad5391-5 > > + - adi,ad5392-3 > > + - adi,ad5392-5 > > You could do this: > > pattern: '^adi,ad53(8[0-4]|9[0-2])-[35]$' Feels fragile and not possible to grep, so I'll stick with the full listing. > > Either way, > > Reviewed-by: Rob Herring <robh@kernel.org> Thanks! Jonathan
diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5380.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5380.yaml new file mode 100644 index 000000000000..d599b418a020 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5380.yaml @@ -0,0 +1,70 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/dac/adi,ad5380.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices AD5380 and similar DACs + +maintainers: + - Lars-Peter Clausen <lars@metafoo.de> + - Jonathan Cameron <jic23@kernel.org> + +description: | + DAC devices supporting both SPI and I2C interfaces. +properties: + compatible: + enum: + - adi,ad5380-3 + - adi,ad5380-5 + - adi,ad5381-3 + - adi,ad5381-5 + - adi,ad5382-3 + - adi,ad5382-5 + - adi,ad5383-3 + - adi,ad5383-5 + - adi,ad5384-3 + - adi,ad5384-5 + - adi,ad5390-3 + - adi,ad5390-5 + - adi,ad5391-3 + - adi,ad5391-5 + - adi,ad5392-3 + - adi,ad5392-5 + + reg: + maxItems: 1 + + vref-supply: + description: + If not supplied devices will use internal regulators. + + spi-max-frequency: true + +additionalProperties: false + +required: + - compatible + - reg + +examples: + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + dac@0 { + reg = <0>; + compatible = "adi,ad5390-5"; + vref-supply = <&dacvref>; + }; + }; + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + dac@42 { + reg = <0x42>; + compatible = "adi,ad5380-3"; + }; + }; +...