diff mbox series

arm64: dts: rockchip: Disable CDN DP on Pinebook Pro

Message ID 20210715164101.11486-1-matthias.bgg@kernel.org (mailing list archive)
State New, archived
Headers show
Series arm64: dts: rockchip: Disable CDN DP on Pinebook Pro | expand

Commit Message

Matthias Brugger July 15, 2021, 4:41 p.m. UTC 
From: Matthias Brugger <mbrugger@suse.com>

The CDN DP needs a PHY and a extcon to work correctly. But no extcon is
provided by the device-tree, which leads to an error:
cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
cdn-dp: probe of fec00000.dp failed with error -22

Disable the CDN DP to make graphic work on the Pinebook Pro.

Reported-by: Guillaume Gardet <guillaume.gardet@arm.com>
Signed-off-by: Matthias Brugger <mbrugger@suse.com>

---

 arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 4 ----
 1 file changed, 4 deletions(-)

Comments

Heiko Stübner July 17, 2021, 9:52 p.m. UTC | #1 
On Thu, 15 Jul 2021 18:41:01 +0200, matthias.bgg@kernel.org wrote:
> The CDN DP needs a PHY and a extcon to work correctly. But no extcon is
> provided by the device-tree, which leads to an error:
> cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
> cdn-dp: probe of fec00000.dp failed with error -22
> 
> Disable the CDN DP to make graphic work on the Pinebook Pro.

Applied, thanks!

[1/1] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro
      commit: 714b35da2b6eace13bfe23ae02330e3b6a2ea4e7

Best regards,
Siva Mahadevan Oct. 23, 2021, 6:34 p.m. UTC | #2 
Heiko Stuebner wrote:
> On Thu, 15 Jul 2021 18:41:01 +0200, matthias.bgg@kernel.org wrote:
> > The CDN DP needs a PHY and a extcon to work correctly. But no extcon is
> > provided by the device-tree, which leads to an error:
> > cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
> > cdn-dp: probe of fec00000.dp failed with error -22
> > 
> > Disable the CDN DP to make graphic work on the Pinebook Pro.
> 
> Applied, thanks!
> 
> [1/1] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro
>       commit: 714b35da2b6eace13bfe23ae02330e3b6a2ea4e7
> 
> Best regards,
> -- 
> Heiko Stuebner <heiko@sntech.de>

Will this patch be submitted to mainline? I can confirm on my pinebook
pro that this solves the issue.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
index 2b5f001ff4a6..9e5d07f5712e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
@@ -385,10 +385,6 @@  mains_charger: dc-charger {
 	};
 };
 
-&cdn_dp {
-	status = "okay";
-};
-
 &cpu_b0 {
 	cpu-supply = <&vdd_cpu_b>;
 };