| Message ID | 1601448168-18396-3-git-send-email-srivasam@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Qualcomm's lpass device tree changes | expand |
On 30/09/2020 07:42, Srinivasa Rao Mandadapu wrote: > From: V Sujith Kumar Reddy <vsujithk@codeaurora.org> > > Add dai link in sc7180-trogdor.dtsi for supporting audio over DP > > Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org> > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index 5724982..850b43e 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -231,6 +231,7 @@ > > audio-jack = <&alc5682>; > > + #sound-dai-cells = <0>; > #address-cells = <1>; > #size-cells = <0>; > > @@ -257,6 +258,17 @@ > sound-dai = <&max98357a>; > }; > }; > + dai-link@2 { > + link-name = "MultiMedia2"; > + reg = <2>; > + cpu { > + sound-dai = <&lpass_cpu 2>; > + }; > + > + codec { > + sound-dai = <&msm_dp>; > + }; > + }; > }; > }; > > @@ -782,6 +794,9 @@ hp_i2c: &i2c9 { > reg = <MI2S_SECONDARY>; > qcom,playback-sd-lines = <0>; > }; > + hdmi-primary@0 { > + reg = <LPASS_DP_RX>; > + }; > }; > > &mdp { >
Quoting Srinivasa Rao Mandadapu (2020-09-29 23:42:48) > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index 5724982..850b43e 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -231,6 +231,7 @@ > > audio-jack = <&alc5682>; > > + #sound-dai-cells = <0>; > #address-cells = <1>; > #size-cells = <0>; > > @@ -257,6 +258,17 @@ > sound-dai = <&max98357a>; > }; > }; Can you please add a newline here? > + dai-link@2 { > + link-name = "MultiMedia2"; > + reg = <2>; > + cpu { > + sound-dai = <&lpass_cpu 2>; > + }; > + > + codec { > + sound-dai = <&msm_dp>; > + }; > + }; > }; > }; > > @@ -782,6 +794,9 @@ hp_i2c: &i2c9 { > reg = <MI2S_SECONDARY>; > qcom,playback-sd-lines = <0>; > }; Can you please add a newline here? > + hdmi-primary@0 { This should be hdmi-primary@2 { Or a more generic node name should be devised. dai@2 perhaps? > + reg = <LPASS_DP_RX>; > + }; > }; >
Quoting Srinivasa Rao Mandadapu (2020-09-29 23:42:48) > From: V Sujith Kumar Reddy <vsujithk@codeaurora.org> > > Add dai link in sc7180-trogdor.dtsi for supporting audio over DP > > Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org> > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index 5724982..850b43e 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -231,6 +231,7 @@ > > audio-jack = <&alc5682>; > > + #sound-dai-cells = <0>; > #address-cells = <1>; > #size-cells = <0>; > > @@ -257,6 +258,17 @@ > sound-dai = <&max98357a>; > }; > }; > + dai-link@2 { > + link-name = "MultiMedia2"; > + reg = <2>; > + cpu { > + sound-dai = <&lpass_cpu 2>; > + }; > + > + codec { > + sound-dai = <&msm_dp>; I see qcom maintainers have picked up the dp node now. Can you resend? This would need to change to mdss_dp. Also incorporate my comments from January this year please.
Hi Stephen!! Thanks for reminder. On 7/21/2021 10:14 AM, Stephen Boyd wrote: > Quoting Srinivasa Rao Mandadapu (2020-09-29 23:42:48) >> From: V Sujith Kumar Reddy <vsujithk@codeaurora.org> >> >> Add dai link in sc7180-trogdor.dtsi for supporting audio over DP >> >> Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org> >> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> >> --- >> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> index 5724982..850b43e 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> @@ -231,6 +231,7 @@ >> >> audio-jack = <&alc5682>; >> >> + #sound-dai-cells = <0>; >> #address-cells = <1>; >> #size-cells = <0>; >> >> @@ -257,6 +258,17 @@ >> sound-dai = <&max98357a>; >> }; >> }; >> + dai-link@2 { >> + link-name = "MultiMedia2"; >> + reg = <2>; >> + cpu { >> + sound-dai = <&lpass_cpu 2>; >> + }; >> + >> + codec { >> + sound-dai = <&msm_dp>; > I see qcom maintainers have picked up the dp node now. Can you resend? > This would need to change to mdss_dp. Also incorporate my comments from > January this year please. Resent the patches. Please check V5 version of patches.
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index 5724982..850b43e 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -231,6 +231,7 @@ audio-jack = <&alc5682>; + #sound-dai-cells = <0>; #address-cells = <1>; #size-cells = <0>; @@ -257,6 +258,17 @@ sound-dai = <&max98357a>; }; }; + dai-link@2 { + link-name = "MultiMedia2"; + reg = <2>; + cpu { + sound-dai = <&lpass_cpu 2>; + }; + + codec { + sound-dai = <&msm_dp>; + }; + }; }; }; @@ -782,6 +794,9 @@ hp_i2c: &i2c9 { reg = <MI2S_SECONDARY>; qcom,playback-sd-lines = <0>; }; + hdmi-primary@0 { + reg = <LPASS_DP_RX>; + }; }; &mdp {