clk: hisilicon: hi3559a: select RESET_HISI

Commit Message

Randy Dunlap July 17, 2021, 4:31 a.m. UTC

The clk-hi3559a driver uses functions from reset.c so it should
select RESET_HISI to avoid build errors.

Fixes these build errors:
aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi3559av100_crg_remove':
clk-hi3559a.c:(.text+0x158): undefined reference to `hisi_reset_exit'
aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi3559av100_crg_probe':
clk-hi3559a.c:(.text+0x1f4): undefined reference to `hisi_reset_init'
aarch64-linux-ld: clk-hi3559a.c:(.text+0x238): undefined reference to `hisi_reset_exit'

Fixes: 6c81966107dc ("clk: hisilicon: Add clock driver for hi3559A SoC")
Signed-off-by: Randy Dunlap <[e-mail]>
Reported-by: kernel test robot <[e-mail]>
Cc: Dongjiu Geng <[e-mail]>
Cc: Stephen Boyd <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: Michael Turquette <[e-mail]>
---
 drivers/clk/hisilicon/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Comments

Dongjiu Geng July 19, 2021, 2:55 a.m. UTC | #1

Randy Dunlap <[e-mail]> 于2021年7月17日周六 下午12:34写道：
>
> The clk-hi3559a driver uses functions from reset.c so it should
> select RESET_HISI to avoid build errors.
>
> Fixes these build errors:
> aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi3559av100_crg_remove':
> clk-hi3559a.c:(.text+0x158): undefined reference to `hisi_reset_exit'
> aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi3559av100_crg_probe':
> clk-hi3559a.c:(.text+0x1f4): undefined reference to `hisi_reset_init'
> aarch64-linux-ld: clk-hi3559a.c:(.text+0x238): undefined reference to `hisi_reset_exit'
>
> Fixes: 6c81966107dc ("clk: hisilicon: Add clock driver for hi3559A SoC")
> Signed-off-by: Randy Dunlap <[e-mail]>
> Reported-by: kernel test robot <[e-mail]>
> Cc: Dongjiu Geng <[e-mail]>
> Cc: Stephen Boyd <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: Michael Turquette <[e-mail]>
> ---
>  drivers/clk/hisilicon/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20210716.orig/drivers/clk/hisilicon/Kconfig
> +++ linux-next-20210716/drivers/clk/hisilicon/Kconfig
> @@ -18,6 +18,7 @@ config COMMON_CLK_HI3519
>  config COMMON_CLK_HI3559A
>         bool "Hi3559A Clock Driver"
>         depends on ARCH_HISI || COMPILE_TEST
> +       select RESET_HISI
>         default ARCH_HISI
>         help
>           Build the clock driver for hi3559a.

Reviewed-by: Dongjiu Geng <[e-mail]>

Stephen Boyd July 27, 2021, 12:23 a.m. UTC | #2

Quoting Randy Dunlap (2021-07-16 21:31:59)
> The clk-hi3559a driver uses functions from reset.c so it should
> select RESET_HISI to avoid build errors.
> 
> Fixes these build errors:
> aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi3559av100_crg_remove':
> clk-hi3559a.c:(.text+0x158): undefined reference to `hisi_reset_exit'
> aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi3559av100_crg_probe':
> clk-hi3559a.c:(.text+0x1f4): undefined reference to `hisi_reset_init'
> aarch64-linux-ld: clk-hi3559a.c:(.text+0x238): undefined reference to `hisi_reset_exit'
> 
> Fixes: 6c81966107dc ("clk: hisilicon: Add clock driver for hi3559A SoC")
> Signed-off-by: Randy Dunlap <[e-mail]>
> Reported-by: kernel test robot <[e-mail]>
> Cc: Dongjiu Geng <[e-mail]>
> Cc: Stephen Boyd <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: Michael Turquette <[e-mail]>
> ---

Applied to clk-fixes

Patch

--- linux-next-20210716.orig/drivers/clk/hisilicon/Kconfig
+++ linux-next-20210716/drivers/clk/hisilicon/Kconfig
@@ -18,6 +18,7 @@  config COMMON_CLK_HI3519
 config COMMON_CLK_HI3559A
 	bool "Hi3559A Clock Driver"
 	depends on ARCH_HISI || COMPILE_TEST
+	select RESET_HISI
 	default ARCH_HISI
 	help
 	  Build the clock driver for hi3559a.