diff mbox series

scsi: target: remove redundant assignment to variable ret

Message ID 20210721101519.42299-1-colin.king@canonical.com (mailing list archive)
State Accepted
Headers show
Series scsi: target: remove redundant assignment to variable ret | expand

Commit Message

Colin King July 21, 2021, 10:15 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The variable ret is being initialized with a value that is never
read, the assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/target/iscsi/cxgbit/cxgbit_ddp.c | 2 +-
 drivers/target/loopback/tcm_loop.c       | 4 ++--
 drivers/target/target_core_iblock.c      | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

Comments

Martin K. Petersen July 27, 2021, 3:09 a.m. UTC | #1 
Colin,

> The variable ret is being initialized with a value that is never read,
> the assignment is redundant and can be removed.

Applied to 5.15/scsi-staging, thanks!
Martin K. Petersen July 29, 2021, 3:38 a.m. UTC | #2 
On Wed, 21 Jul 2021 11:15:19 +0100, Colin King wrote:

> The variable ret is being initialized with a value that is never
> read, the assignment is redundant and can be removed.

Applied to 5.15/scsi-queue, thanks!

[1/1] scsi: target: remove redundant assignment to variable ret
      https://git.kernel.org/mkp/scsi/c/8f13142ac2eb
diff mbox series

Patch

diff --git a/drivers/target/iscsi/cxgbit/cxgbit_ddp.c b/drivers/target/iscsi/cxgbit/cxgbit_ddp.c
index b044999ad002..072afd070f3e 100644
--- a/drivers/target/iscsi/cxgbit/cxgbit_ddp.c
+++ b/drivers/target/iscsi/cxgbit/cxgbit_ddp.c
@@ -234,7 +234,7 @@  cxgbit_get_r2t_ttt(struct iscsi_conn *conn, struct iscsi_cmd *cmd,
 	struct cxgbit_device *cdev = csk->com.cdev;
 	struct cxgbit_cmd *ccmd = iscsit_priv_cmd(cmd);
 	struct cxgbi_task_tag_info *ttinfo = &ccmd->ttinfo;
-	int ret = -EINVAL;
+	int ret;
 
 	if ((!ccmd->setup_ddp) ||
 	    (!test_bit(CSK_DDP_ENABLE, &csk->com.flags)))
diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c
index 6d0b0e67e79e..fdc36274cb39 100644
--- a/drivers/target/loopback/tcm_loop.c
+++ b/drivers/target/loopback/tcm_loop.c
@@ -241,7 +241,7 @@  static int tcm_loop_abort_task(struct scsi_cmnd *sc)
 {
 	struct tcm_loop_hba *tl_hba;
 	struct tcm_loop_tpg *tl_tpg;
-	int ret = FAILED;
+	int ret;
 
 	/*
 	 * Locate the tcm_loop_hba_t pointer
@@ -261,7 +261,7 @@  static int tcm_loop_device_reset(struct scsi_cmnd *sc)
 {
 	struct tcm_loop_hba *tl_hba;
 	struct tcm_loop_tpg *tl_tpg;
-	int ret = FAILED;
+	int ret;
 
 	/*
 	 * Locate the tcm_loop_hba_t pointer
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index 44d9d028f716..4069a1edcfa3 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -83,7 +83,7 @@  static int iblock_configure_device(struct se_device *dev)
 	struct blk_integrity *bi;
 	fmode_t mode;
 	unsigned int max_write_zeroes_sectors;
-	int ret = -ENOMEM;
+	int ret;
 
 	if (!(ib_dev->ibd_flags & IBDF_HAS_UDEV_PATH)) {
 		pr_err("Missing udev_path= parameters for IBLOCK\n");