| Message ID | 20210727223042.48150-3-rikard.falkeborn@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | drivers/watchdog: Constify static struct watchdog_ops | expand |
On Wed, Jul 28, 2021 at 12:30:41AM +0200, Rikard Falkeborn wrote: > The struct tqmx86_wdt_ops is only assigned to the ops pointer in the > watchdog_device struct, which is a pointer to const struct watchdog_ops. > Make it const to allow the compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/tqmx86_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/tqmx86_wdt.c b/drivers/watchdog/tqmx86_wdt.c > index 72d0b0adde38..83860e94ce9d 100644 > --- a/drivers/watchdog/tqmx86_wdt.c > +++ b/drivers/watchdog/tqmx86_wdt.c > @@ -62,7 +62,7 @@ static const struct watchdog_info tqmx86_wdt_info = { > .identity = "TQMx86 Watchdog", > }; > > -static struct watchdog_ops tqmx86_wdt_ops = { > +static const struct watchdog_ops tqmx86_wdt_ops = { > .owner = THIS_MODULE, > .start = tqmx86_wdt_start, > .set_timeout = tqmx86_wdt_set_timeout, > -- > 2.32.0 >
diff --git a/drivers/watchdog/tqmx86_wdt.c b/drivers/watchdog/tqmx86_wdt.c index 72d0b0adde38..83860e94ce9d 100644 --- a/drivers/watchdog/tqmx86_wdt.c +++ b/drivers/watchdog/tqmx86_wdt.c @@ -62,7 +62,7 @@ static const struct watchdog_info tqmx86_wdt_info = { .identity = "TQMx86 Watchdog", }; -static struct watchdog_ops tqmx86_wdt_ops = { +static const struct watchdog_ops tqmx86_wdt_ops = { .owner = THIS_MODULE, .start = tqmx86_wdt_start, .set_timeout = tqmx86_wdt_set_timeout,
The struct tqmx86_wdt_ops is only assigned to the ops pointer in the watchdog_device struct, which is a pointer to const struct watchdog_ops. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> --- drivers/watchdog/tqmx86_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)