| Message ID | 20210729201100.3994-3-linux.amoon@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add Reset controller to Ethernet PHY | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 9 of 9 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | fail | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 16 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Fri, 2021-07-30 at 01:40 +0530, Anand Moon wrote: > Used new reset id for reset controller as it conflict > with the core reset id. > > Fixes: b96446541d83 ("ARM: dts: meson8b: extend ethernet controller description") > > Cc: Jerome Brunet <jbrunet@baylibre.com> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > arch/arm/boot/dts/meson8b.dtsi | 2 +- > arch/arm/boot/dts/meson8m2.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi > index c02b03cbcdf4..cb3a579d09ef 100644 > --- a/arch/arm/boot/dts/meson8b.dtsi > +++ b/arch/arm/boot/dts/meson8b.dtsi > @@ -511,7 +511,7 @@ ðmac { > tx-fifo-depth = <2048>; > > resets = <&reset RESET_ETHERNET>; > - reset-names = "stmmaceth"; > + reset-names = "ethreset"; This looks like an incompatible change. Is the "stmmaceth" reset not used? It is documented as "MAC reset signal" in [1]. So a PHY reset should be separate from this. [1] Documentation/devicetree/bindings/net/snps,dwmac.yaml regards Philipp
Hi Philipp, Thanks for your review comments. On Fri, 30 Jul 2021 at 15:16, Philipp Zabel <p.zabel@pengutronix.de> wrote: > > On Fri, 2021-07-30 at 01:40 +0530, Anand Moon wrote: > > Used new reset id for reset controller as it conflict > > with the core reset id. > > > > Fixes: b96446541d83 ("ARM: dts: meson8b: extend ethernet controller description") > > > > Cc: Jerome Brunet <jbrunet@baylibre.com> > > Cc: Neil Armstrong <narmstrong@baylibre.com> > > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > --- > > arch/arm/boot/dts/meson8b.dtsi | 2 +- > > arch/arm/boot/dts/meson8m2.dtsi | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi > > index c02b03cbcdf4..cb3a579d09ef 100644 > > --- a/arch/arm/boot/dts/meson8b.dtsi > > +++ b/arch/arm/boot/dts/meson8b.dtsi > > @@ -511,7 +511,7 @@ ðmac { > > tx-fifo-depth = <2048>; > > > > resets = <&reset RESET_ETHERNET>; > > - reset-names = "stmmaceth"; > > + reset-names = "ethreset"; > > This looks like an incompatible change. Is the "stmmaceth" reset not > used? It is documented as "MAC reset signal" in [1]. So a PHY reset > should be separate from this. > > [1] Documentation/devicetree/bindings/net/snps,dwmac.yaml > From the above device tree binding is been used below. reset-names: const: stmmaceth While testing new reset driver changes I was getting conflict with reset id, see the below links hence I opted for a new reset-names = "ethreset". [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/stmicro/stmmac/stmmac.h?h=v5.14-rc3#n12 [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c?h=v5.14-rc3#n598 > regards > Philipp Thanks -Anand
diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi index c02b03cbcdf4..cb3a579d09ef 100644 --- a/arch/arm/boot/dts/meson8b.dtsi +++ b/arch/arm/boot/dts/meson8b.dtsi @@ -511,7 +511,7 @@ ðmac { tx-fifo-depth = <2048>; resets = <&reset RESET_ETHERNET>; - reset-names = "stmmaceth"; + reset-names = "ethreset"; power-domains = <&pwrc PWRC_MESON8_ETHERNET_MEM_ID>; }; diff --git a/arch/arm/boot/dts/meson8m2.dtsi b/arch/arm/boot/dts/meson8m2.dtsi index 6725dd9fd825..cfaf60c4ba5f 100644 --- a/arch/arm/boot/dts/meson8m2.dtsi +++ b/arch/arm/boot/dts/meson8m2.dtsi @@ -34,7 +34,7 @@ ðmac { <&clkc CLKID_FCLK_DIV2>; clock-names = "stmmaceth", "clkin0", "clkin1", "timing-adjustment"; resets = <&reset RESET_ETHERNET>; - reset-names = "stmmaceth"; + reset-names = "ethreset"; }; &pinctrl_aobus {
Used new reset id for reset controller as it conflict with the core reset id. Fixes: b96446541d83 ("ARM: dts: meson8b: extend ethernet controller description") Cc: Jerome Brunet <jbrunet@baylibre.com> Cc: Neil Armstrong <narmstrong@baylibre.com> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- arch/arm/boot/dts/meson8b.dtsi | 2 +- arch/arm/boot/dts/meson8m2.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)