| Message ID | 20210728153736.15240-4-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | drm: Extend COMPILE_TEST support to some ARM drivers | expand |
Hi Laurent, On Wed, Jul 28, 2021 at 5:37 PM Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > To extend test coverage, relax the dependency on ARCH_MXC to also enable > compilation when COMPILE_TEST is selected. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Thanks for your patch! > --- a/drivers/gpu/drm/imx/dcss/Kconfig > +++ b/drivers/gpu/drm/imx/dcss/Kconfig > @@ -3,7 +3,8 @@ config DRM_IMX_DCSS > select IMX_IRQSTEER > select DRM_KMS_CMA_HELPER > select VIDEOMODE_HELPERS > - depends on DRM && ARCH_MXC && ARM64 > + depends on DRM > + depends on ARM64 && (ARCH_MXC || COMPILE_TEST) As you now have two depends statements, I think this would be easier to read by maintaining a strict separation between "hard" and "soft" dependencies: depends on DRM && ARM64 depends on ARCH_MXC || COMPILE_TEST Gr{oetje,eeting}s, Geert
On Fri, 2021-07-30 at 14:10 +0200, Geert Uytterhoeven wrote: > Hi Laurent, > > On Wed, Jul 28, 2021 at 5:37 PM Laurent Pinchart > <laurent.pinchart+renesas@ideasonboard.com> wrote: > > To extend test coverage, relax the dependency on ARCH_MXC to also enable > > compilation when COMPILE_TEST is selected. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > Thanks for your patch! > > > --- a/drivers/gpu/drm/imx/dcss/Kconfig > > +++ b/drivers/gpu/drm/imx/dcss/Kconfig > > @@ -3,7 +3,8 @@ config DRM_IMX_DCSS > > select IMX_IRQSTEER > > select DRM_KMS_CMA_HELPER > > select VIDEOMODE_HELPERS > > - depends on DRM && ARCH_MXC && ARM64 > > + depends on DRM > > + depends on ARM64 && (ARCH_MXC || COMPILE_TEST) > > As you now have two depends statements, I think this would be easier > to read by maintaining a strict separation between "hard" and "soft" > dependencies: > > depends on DRM && ARM64 > depends on ARCH_MXC || COMPILE_TEST I would let (ARCH_MXC && ARM64) stay together, and as Tomi suggested, lift the ARM64 limitation if COMPILE_TEST is enabled: depends on DRM depends on (ARCH_MXC && ARM64) || COMPILE_TEST regards Philipp
diff --git a/drivers/gpu/drm/imx/dcss/Kconfig b/drivers/gpu/drm/imx/dcss/Kconfig index 2b17a964ff05..ad9844fb85ac 100644 --- a/drivers/gpu/drm/imx/dcss/Kconfig +++ b/drivers/gpu/drm/imx/dcss/Kconfig @@ -3,7 +3,8 @@ config DRM_IMX_DCSS select IMX_IRQSTEER select DRM_KMS_CMA_HELPER select VIDEOMODE_HELPERS - depends on DRM && ARCH_MXC && ARM64 + depends on DRM + depends on ARM64 && (ARCH_MXC || COMPILE_TEST) help Choose this if you have a NXP i.MX8MQ based system and want to use the Display Controller Subsystem. This option enables DCSS support.
To extend test coverage, relax the dependency on ARCH_MXC to also enable compilation when COMPILE_TEST is selected. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- drivers/gpu/drm/imx/dcss/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)