| Message ID | 20210803100016.314960-1-atenart@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4039146777a91e1576da2bf38e0d8a1061a1ae47 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: ipv6: fix returned variable type in ip6_skb_dst_mtu | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | fail | 1 blamed authors not CCed: dsahern@kernel.org; 2 maintainers not CCed: yoshfuji@linux-ipv6.org dsahern@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 402 this patch: 402 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 413 this patch: 413 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 3 Aug 2021 12:00:16 +0200 you wrote: > The patch fixing the returned value of ip6_skb_dst_mtu (int -> unsigned > int) was rebased between its initial review and the version applied. In > the meantime fade56410c22 was applied, which added a new variable (int) > used as the returned value. This lead to a mismatch between the function > prototype and the variable used as the return value. > > Fixes: 40fc3054b458 ("net: ipv6: fix return value of ip6_skb_dst_mtu") > Cc: Vadim Fedorenko <vfedorenko@novek.ru> > Signed-off-by: Antoine Tenart <atenart@kernel.org> > > [...] Here is the summary with links: - [net] net: ipv6: fix returned variable type in ip6_skb_dst_mtu https://git.kernel.org/netdev/net/c/4039146777a9 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h index 625a38ccb5d9..0bf09a9bca4e 100644 --- a/include/net/ip6_route.h +++ b/include/net/ip6_route.h @@ -265,7 +265,7 @@ int ip6_fragment(struct net *net, struct sock *sk, struct sk_buff *skb, static inline unsigned int ip6_skb_dst_mtu(struct sk_buff *skb) { - int mtu; + unsigned int mtu; struct ipv6_pinfo *np = skb->sk && !dev_recursion_level() ? inet6_sk(skb->sk) : NULL;
The patch fixing the returned value of ip6_skb_dst_mtu (int -> unsigned int) was rebased between its initial review and the version applied. In the meantime fade56410c22 was applied, which added a new variable (int) used as the returned value. This lead to a mismatch between the function prototype and the variable used as the return value. Fixes: 40fc3054b458 ("net: ipv6: fix return value of ip6_skb_dst_mtu") Cc: Vadim Fedorenko <vfedorenko@novek.ru> Signed-off-by: Antoine Tenart <atenart@kernel.org> --- include/net/ip6_route.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)