diff mbox series

[1/2] remoteproc: fix an typo in fw_elf_get_class code comments

Message ID 20210706142156.952794-1-aisheng.dong@nxp.com (mailing list archive)
State Accepted
Commit c080128b6f05cb803d830e6bf2ec0b214435ce38
Headers show
Series [1/2] remoteproc: fix an typo in fw_elf_get_class code comments | expand

Commit Message

Aisheng Dong July 6, 2021, 2:21 p.m. UTC
Drop 'and' which looks like unnecessary.

Fixes: 73516a33588c ("remoteproc: Add elf helpers to access elf64 and elf32 fields")
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 drivers/remoteproc/remoteproc_elf_helpers.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mathieu Poirier July 12, 2021, 5:29 p.m. UTC | #1
On Tue, Jul 06, 2021 at 10:21:55PM +0800, Dong Aisheng wrote:
> Drop 'and' which looks like unnecessary.
> 
> Fixes: 73516a33588c ("remoteproc: Add elf helpers to access elf64 and elf32 fields")
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  drivers/remoteproc/remoteproc_elf_helpers.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/remoteproc_elf_helpers.h b/drivers/remoteproc/remoteproc_elf_helpers.h
> index 26404e68e17a..e6de53a5000c 100644
> --- a/drivers/remoteproc/remoteproc_elf_helpers.h
> +++ b/drivers/remoteproc/remoteproc_elf_helpers.h
> @@ -15,7 +15,7 @@
>   * fw_elf_get_class - Get elf class
>   * @fw: the ELF firmware image
>   *
> - * Note that we use and elf32_hdr to access the class since the start of the
> + * Note that we use elf32_hdr to access the class since the start of the
>   * struct is the same for both elf class

The sentence should read:

"Note that we use an elf32_hdr..."

With the above:

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

>   *
>   * Return: elf class of the firmware
> -- 
> 2.25.1
>
patchwork-bot+linux-remoteproc@kernel.org Aug. 4, 2021, 7:31 p.m. UTC | #2
Hello:

This series was applied to andersson/remoteproc.git (refs/heads/for-next):

On Tue,  6 Jul 2021 22:21:55 +0800 you wrote:
> Drop 'and' which looks like unnecessary.
> 
> Fixes: 73516a33588c ("remoteproc: Add elf helpers to access elf64 and elf32 fields")
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  drivers/remoteproc/remoteproc_elf_helpers.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [1/2] remoteproc: fix an typo in fw_elf_get_class code comments
    https://git.kernel.org/andersson/remoteproc/c/c080128b6f05
  - [2/2] remoteproc: fix kernel doc for struct rproc_ops
    https://git.kernel.org/andersson/remoteproc/c/147b589c5f44

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/remoteproc/remoteproc_elf_helpers.h b/drivers/remoteproc/remoteproc_elf_helpers.h
index 26404e68e17a..e6de53a5000c 100644
--- a/drivers/remoteproc/remoteproc_elf_helpers.h
+++ b/drivers/remoteproc/remoteproc_elf_helpers.h
@@ -15,7 +15,7 @@ 
  * fw_elf_get_class - Get elf class
  * @fw: the ELF firmware image
  *
- * Note that we use and elf32_hdr to access the class since the start of the
+ * Note that we use elf32_hdr to access the class since the start of the
  * struct is the same for both elf class
  *
  * Return: elf class of the firmware