| Message ID | 20210805033206.1295269-5-aisheng.dong@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3,1/5] remoteproc: fix the wrong default value of is_iomem | expand |
> Subject: [PATCH v3 5/5] remoteproc: imx_rproc: change to ioremap_wc for > dram > > DRAM is not io memory, so changed to ioremap_wc. This is also aligned with > core io accessories. e.g. memcpy/memset and cpu direct access. > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Mathieu Poirier <mathieu.poirier@linaro.org> > Cc: Peng Fan <peng.fan@nxp.com> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> Reviewed-by: Peng Fan <peng.fan@nxp.com> > --- > v2->v3: > * patch content unchanged. > Only drop the wrong tag in v2 > Tested on MX8MQ and MX8MP, MX7ULP. > v1->v2: > * new patch > --- > drivers/remoteproc/imx_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/imx_rproc.c > b/drivers/remoteproc/imx_rproc.c index ff620688fad9..4ae416ba5080 > 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -597,7 +597,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > break; > > /* Not use resource version, because we might share region */ > - priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, > resource_size(&res)); > + priv->mem[b].cpu_addr = devm_ioremap_wc(&pdev->dev, > res.start, > +resource_size(&res)); > if (!priv->mem[b].cpu_addr) { > dev_err(dev, "failed to remap %pr\n", &res); > return -ENOMEM; > -- > 2.25.1
On Thu, Aug 05, 2021 at 09:57:10AM +0000, Peng Fan (OSS) wrote: > > Subject: [PATCH v3 5/5] remoteproc: imx_rproc: change to ioremap_wc for > > dram > > > > DRAM is not io memory, so changed to ioremap_wc. This is also aligned with > > core io accessories. e.g. memcpy/memset and cpu direct access. > > > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > Cc: Mathieu Poirier <mathieu.poirier@linaro.org> > > Cc: Peng Fan <peng.fan@nxp.com> > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > Reviewed-by: Peng Fan <peng.fan@nxp.com> > Did you test this one as well? > > --- > > v2->v3: > > * patch content unchanged. > > Only drop the wrong tag in v2 > > Tested on MX8MQ and MX8MP, MX7ULP. > > v1->v2: > > * new patch > > --- > > drivers/remoteproc/imx_rproc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > b/drivers/remoteproc/imx_rproc.c index ff620688fad9..4ae416ba5080 > > 100644 > > --- a/drivers/remoteproc/imx_rproc.c > > +++ b/drivers/remoteproc/imx_rproc.c > > @@ -597,7 +597,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > > break; > > > > /* Not use resource version, because we might share region */ > > - priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, > > resource_size(&res)); > > + priv->mem[b].cpu_addr = devm_ioremap_wc(&pdev->dev, > > res.start, > > +resource_size(&res)); > > if (!priv->mem[b].cpu_addr) { > > dev_err(dev, "failed to remap %pr\n", &res); > > return -ENOMEM; > > -- > > 2.25.1 >
> -----Original Message----- > From: Mathieu Poirier [mailto:mathieu.poirier@linaro.org] > Sent: 2021年8月6日 0:37 > To: Peng Fan (OSS) <peng.fan@oss.nxp.com> > Cc: Aisheng Dong <aisheng.dong@nxp.com>; > linux-remoteproc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > ohad@wizery.com; dongas86@gmail.com; bjorn.andersson@linaro.org; > cleger@kalray.eu > Subject: Re: [PATCH v3 5/5] remoteproc: imx_rproc: change to ioremap_wc > for dram > > On Thu, Aug 05, 2021 at 09:57:10AM +0000, Peng Fan (OSS) wrote: > > > Subject: [PATCH v3 5/5] remoteproc: imx_rproc: change to ioremap_wc > > > for dram > > > > > > DRAM is not io memory, so changed to ioremap_wc. This is also > > > aligned with core io accessories. e.g. memcpy/memset and cpu direct > access. > > > > > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > > Cc: Mathieu Poirier <mathieu.poirier@linaro.org> > > > Cc: Peng Fan <peng.fan@nxp.com> > > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > > > Reviewed-by: Peng Fan <peng.fan@nxp.com> > > > > Did you test this one as well? Yes, Tested-by: Peng Fan <peng.fan@nxp.com> I'll take the pachset, respin the tags and send a v4. Thanks, Peng. > > > > --- > > > v2->v3: > > > * patch content unchanged. > > > Only drop the wrong tag in v2 > > > Tested on MX8MQ and MX8MP, MX7ULP. > > > v1->v2: > > > * new patch > > > --- > > > drivers/remoteproc/imx_rproc.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > > b/drivers/remoteproc/imx_rproc.c index ff620688fad9..4ae416ba5080 > > > 100644 > > > --- a/drivers/remoteproc/imx_rproc.c > > > +++ b/drivers/remoteproc/imx_rproc.c > > > @@ -597,7 +597,7 @@ static int imx_rproc_addr_init(struct imx_rproc > *priv, > > > break; > > > > > > /* Not use resource version, because we might share region */ > > > - priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, > > > resource_size(&res)); > > > + priv->mem[b].cpu_addr = devm_ioremap_wc(&pdev->dev, > > > res.start, > > > +resource_size(&res)); > > > if (!priv->mem[b].cpu_addr) { > > > dev_err(dev, "failed to remap %pr\n", &res); > > > return -ENOMEM; > > > -- > > > 2.25.1 > >
diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index ff620688fad9..4ae416ba5080 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -597,7 +597,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, break; /* Not use resource version, because we might share region */ - priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, resource_size(&res)); + priv->mem[b].cpu_addr = devm_ioremap_wc(&pdev->dev, res.start, resource_size(&res)); if (!priv->mem[b].cpu_addr) { dev_err(dev, "failed to remap %pr\n", &res); return -ENOMEM;
DRAM is not io memory, so changed to ioremap_wc. This is also aligned with core io accessories. e.g. memcpy/memset and cpu direct access. Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Peng Fan <peng.fan@nxp.com> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- v2->v3: * patch content unchanged. Only drop the wrong tag in v2 Tested on MX8MQ and MX8MP, MX7ULP. v1->v2: * new patch --- drivers/remoteproc/imx_rproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)