| Message ID | 20210729155805.2830-7-james.clark@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | perf tools: Warning fixes | expand |
Em Thu, Jul 29, 2021 at 04:58:05PM +0100, James Clark escreveu: > Currently decode will silently fail if no binary data is available for > the decode. This is made worse if only partial data is available because > the decode will appear to work, but any trace from that missing DSO will > silently not be generated. > > Add a UI popup once if there is any data missing, and then warn in the > bottom left for each individual DSO that's missing. Looks ok to me (the last 3 patches in this series, the rest I applied already), can I get some Acked-by/Reviewed-by from the CoreSight people? Thanks, - Arnaldo > Signed-off-by: James Clark <james.clark@arm.com> > --- > tools/perf/util/cs-etm.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > index 32ad92d3e454..e6851260d059 100644 > --- a/tools/perf/util/cs-etm.c > +++ b/tools/perf/util/cs-etm.c > @@ -746,8 +746,16 @@ static u32 cs_etm__mem_access(struct cs_etm_queue *etmq, u8 trace_chan_id, > > len = dso__data_read_offset(al.map->dso, machine, offset, buffer, size); > > - if (len <= 0) > + if (len <= 0) { > + ui__warning_once("CS ETM Trace: Missing DSO. Use 'perf archive' to export data from the traced system.\n"); > + if (!al.map->dso->auxtrace_warned) { > + pr_err("CS ETM Trace: Debug data not found for address %#"PRIx64" in %s\n", > + address, > + al.map->dso->long_name ? al.map->dso->long_name : "Unknown"); > + al.map->dso->auxtrace_warned = true; > + } > return 0; > + } > > return len; > } > -- > 2.28.0 >
On Thu, Jul 29, 2021 at 04:58:05PM +0100, James Clark wrote: > Currently decode will silently fail if no binary data is available for > the decode. This is made worse if only partial data is available because > the decode will appear to work, but any trace from that missing DSO will > silently not be generated. > > Add a UI popup once if there is any data missing, and then warn in the > bottom left for each individual DSO that's missing. > > Signed-off-by: James Clark <james.clark@arm.com> > --- > tools/perf/util/cs-etm.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > index 32ad92d3e454..e6851260d059 100644 > --- a/tools/perf/util/cs-etm.c > +++ b/tools/perf/util/cs-etm.c > @@ -746,8 +746,16 @@ static u32 cs_etm__mem_access(struct cs_etm_queue *etmq, u8 trace_chan_id, > > len = dso__data_read_offset(al.map->dso, machine, offset, buffer, size); > > - if (len <= 0) > + if (len <= 0) { > + ui__warning_once("CS ETM Trace: Missing DSO. Use 'perf archive' to export data from the traced system.\n"); > + if (!al.map->dso->auxtrace_warned) { > + pr_err("CS ETM Trace: Debug data not found for address %#"PRIx64" in %s\n", > + address, > + al.map->dso->long_name ? al.map->dso->long_name : "Unknown"); > + al.map->dso->auxtrace_warned = true; > + } This is very useful. Just one comment: in particularly if the perf fails to find the kernel symbols, the user needs to enable config "CONFIG_PROC_KCORE=y" or specify option "-k /path/to/vmlinux". In this case, using 'perf archive' is not helpful. So I think the UI warning can be imporved like: ui__warning_once("CS ETM Trace: Missing DSO. Use 'perf archive' to export data from the traced system.\n" " Enable CONFIG_PROC_KCORE or use option '-k /path/to/vmlinux' for kernel symbols\n"); With this improvement, the patch looks good to me: Reviewed-by: Leo Yan <leo.yan@linaro.org> > return 0; > + } > > return len; > } > -- > 2.28.0 >
On Mon, Aug 02, 2021 at 11:51:58AM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Jul 29, 2021 at 04:58:05PM +0100, James Clark escreveu: > > Currently decode will silently fail if no binary data is available for > > the decode. This is made worse if only partial data is available because > > the decode will appear to work, but any trace from that missing DSO will > > silently not be generated. > > > > Add a UI popup once if there is any data missing, and then warn in the > > bottom left for each individual DSO that's missing. > > Looks ok to me (the last 3 patches in this series, the rest I applied > already), can I get some Acked-by/Reviewed-by from the CoreSight people? > I have a substantial backlog of patches to go through and I will be away for the next two weeks. As such it will be some time before I get to review this set. Regards, Mathieu > Thanks, > > - Arnaldo > > > Signed-off-by: James Clark <james.clark@arm.com> > > --- > > tools/perf/util/cs-etm.c | 10 +++++++++- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > > index 32ad92d3e454..e6851260d059 100644 > > --- a/tools/perf/util/cs-etm.c > > +++ b/tools/perf/util/cs-etm.c > > @@ -746,8 +746,16 @@ static u32 cs_etm__mem_access(struct cs_etm_queue *etmq, u8 trace_chan_id, > > > > len = dso__data_read_offset(al.map->dso, machine, offset, buffer, size); > > > > - if (len <= 0) > > + if (len <= 0) { > > + ui__warning_once("CS ETM Trace: Missing DSO. Use 'perf archive' to export data from the traced system.\n"); > > + if (!al.map->dso->auxtrace_warned) { > > + pr_err("CS ETM Trace: Debug data not found for address %#"PRIx64" in %s\n", > > + address, > > + al.map->dso->long_name ? al.map->dso->long_name : "Unknown"); > > + al.map->dso->auxtrace_warned = true; > > + } > > return 0; > > + } > > > > return len; > > } > > -- > > 2.28.0 > > > > -- > > - Arnaldo
HI James, On Mon, 2 Aug 2021 at 18:03, Mathieu Poirier <mathieu.poirier@linaro.org> wrote: > > On Mon, Aug 02, 2021 at 11:51:58AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, Jul 29, 2021 at 04:58:05PM +0100, James Clark escreveu: > > > Currently decode will silently fail if no binary data is available for > > > the decode. This is made worse if only partial data is available because > > > the decode will appear to work, but any trace from that missing DSO will > > > silently not be generated. > > > The decoder actually outputs a OCSD_GEN_TRC_ELEM_ADDR_NACC packet if binary memory data is missing. These packets are currently ignored by perf / cs-etm-decoder.c. I think this per DSO warning is fine, but perhaps at some point add in handling for OCSD_GEN_TRC_ELEM_ADDR_NACC - which perhaps is only active when dumping trace packets. Regards Mike > > > Add a UI popup once if there is any data missing, and then warn in the > > > bottom left for each individual DSO that's missing. > > > > Looks ok to me (the last 3 patches in this series, the rest I applied > > already), can I get some Acked-by/Reviewed-by from the CoreSight people? > > > > I have a substantial backlog of patches to go through and I will be away for the > next two weeks. As such it will be some time before I get to review this set. > > Regards, > Mathieu > > > Thanks, > > > > - Arnaldo > > > > > Signed-off-by: James Clark <james.clark@arm.com> > > > --- > > > tools/perf/util/cs-etm.c | 10 +++++++++- > > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > > > index 32ad92d3e454..e6851260d059 100644 > > > --- a/tools/perf/util/cs-etm.c > > > +++ b/tools/perf/util/cs-etm.c > > > @@ -746,8 +746,16 @@ static u32 cs_etm__mem_access(struct cs_etm_queue *etmq, u8 trace_chan_id, > > > > > > len = dso__data_read_offset(al.map->dso, machine, offset, buffer, size); > > > > > > - if (len <= 0) > > > + if (len <= 0) { > > > + ui__warning_once("CS ETM Trace: Missing DSO. Use 'perf archive' to export data from the traced system.\n"); > > > + if (!al.map->dso->auxtrace_warned) { > > > + pr_err("CS ETM Trace: Debug data not found for address %#"PRIx64" in %s\n", > > > + address, > > > + al.map->dso->long_name ? al.map->dso->long_name : "Unknown"); > > > + al.map->dso->auxtrace_warned = true; > > > + } > > > return 0; > > > + } > > > > > > return len; > > > } > > > -- > > > 2.28.0 > > > > > > > -- > > > > - Arnaldo
Em Mon, Aug 02, 2021 at 11:41:45PM +0800, Leo Yan escreveu: > On Thu, Jul 29, 2021 at 04:58:05PM +0100, James Clark wrote: > > Currently decode will silently fail if no binary data is available for > > the decode. This is made worse if only partial data is available because > > the decode will appear to work, but any trace from that missing DSO will > > silently not be generated. > > > > Add a UI popup once if there is any data missing, and then warn in the > > bottom left for each individual DSO that's missing. > > > > Signed-off-by: James Clark <james.clark@arm.com> > > --- > > tools/perf/util/cs-etm.c | 10 +++++++++- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > > index 32ad92d3e454..e6851260d059 100644 > > --- a/tools/perf/util/cs-etm.c > > +++ b/tools/perf/util/cs-etm.c > > @@ -746,8 +746,16 @@ static u32 cs_etm__mem_access(struct cs_etm_queue *etmq, u8 trace_chan_id, > > > > len = dso__data_read_offset(al.map->dso, machine, offset, buffer, size); > > > > - if (len <= 0) > > + if (len <= 0) { > > + ui__warning_once("CS ETM Trace: Missing DSO. Use 'perf archive' to export data from the traced system.\n"); > > + if (!al.map->dso->auxtrace_warned) { > > + pr_err("CS ETM Trace: Debug data not found for address %#"PRIx64" in %s\n", > > + address, > > + al.map->dso->long_name ? al.map->dso->long_name : "Unknown"); > > + al.map->dso->auxtrace_warned = true; > > + } > > This is very useful. > > Just one comment: in particularly if the perf fails to find the kernel > symbols, the user needs to enable config "CONFIG_PROC_KCORE=y" or > specify option "-k /path/to/vmlinux". In this case, using 'perf > archive' is not helpful. So I think the UI warning can be imporved > like: > > ui__warning_once("CS ETM Trace: Missing DSO. Use 'perf archive' to export data from the traced system.\n" > " Enable CONFIG_PROC_KCORE or use option '-k /path/to/vmlinux' for kernel symbols\n"); one can also use debuginfod-client, which, as time passes, probably will be the main way of finding DSOs now that we have build-ids in PERF_RECORD_MMAP2 and debuginfod servers such as: export DEBUGINFOD_URLS=https://debuginfod.fedoraproject.org/ https://fedoraproject.org/wiki/Debuginfod > With this improvement, the patch looks good to me: > > Reviewed-by: Leo Yan <leo.yan@linaro.org> Does this apply to the other 5 patches in this series? - Arnaldo > > return 0; > > + } > > > > return len; > > } > > -- > > 2.28.0 > >
On Tue, Aug 03, 2021 at 10:24:09AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Aug 02, 2021 at 11:41:45PM +0800, Leo Yan escreveu: > > On Thu, Jul 29, 2021 at 04:58:05PM +0100, James Clark wrote: > > > Currently decode will silently fail if no binary data is available for > > > the decode. This is made worse if only partial data is available because > > > the decode will appear to work, but any trace from that missing DSO will > > > silently not be generated. > > > > > > Add a UI popup once if there is any data missing, and then warn in the > > > bottom left for each individual DSO that's missing. > > > > > > Signed-off-by: James Clark <james.clark@arm.com> > > > --- > > > tools/perf/util/cs-etm.c | 10 +++++++++- > > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > > > index 32ad92d3e454..e6851260d059 100644 > > > --- a/tools/perf/util/cs-etm.c > > > +++ b/tools/perf/util/cs-etm.c > > > @@ -746,8 +746,16 @@ static u32 cs_etm__mem_access(struct cs_etm_queue *etmq, u8 trace_chan_id, > > > > > > len = dso__data_read_offset(al.map->dso, machine, offset, buffer, size); > > > > > > - if (len <= 0) > > > + if (len <= 0) { > > > + ui__warning_once("CS ETM Trace: Missing DSO. Use 'perf archive' to export data from the traced system.\n"); > > > + if (!al.map->dso->auxtrace_warned) { > > > + pr_err("CS ETM Trace: Debug data not found for address %#"PRIx64" in %s\n", > > > + address, > > > + al.map->dso->long_name ? al.map->dso->long_name : "Unknown"); > > > + al.map->dso->auxtrace_warned = true; > > > + } > > > > This is very useful. > > > > Just one comment: in particularly if the perf fails to find the kernel > > symbols, the user needs to enable config "CONFIG_PROC_KCORE=y" or > > specify option "-k /path/to/vmlinux". In this case, using 'perf > > archive' is not helpful. So I think the UI warning can be imporved > > like: > > > > ui__warning_once("CS ETM Trace: Missing DSO. Use 'perf archive' to export data from the traced system.\n" > > " Enable CONFIG_PROC_KCORE or use option '-k /path/to/vmlinux' for kernel symbols\n"); > > one can also use debuginfod-client, which, as time passes, probably will > be the main way of finding DSOs now that we have build-ids in > PERF_RECORD_MMAP2 and debuginfod servers such as: > > export DEBUGINFOD_URLS=https://debuginfod.fedoraproject.org/ If so, maybe should use more general description for missing DSO. > https://fedoraproject.org/wiki/Debuginfod > > > With this improvement, the patch looks good to me: > > > > Reviewed-by: Leo Yan <leo.yan@linaro.org> > > Does this apply to the other 5 patches in this series? I finished to reivew patches 01, 04, 05, 06/06, so my review tag can apply on these patches. Current patch 06/06 needs James to improve for the comments. Thanks, Leo
On 03/08/2021 15:01, Leo Yan wrote: >> one can also use debuginfod-client, which, as time passes, probably will >> be the main way of finding DSOs now that we have build-ids in >> PERF_RECORD_MMAP2 and debuginfod servers such as: >> >> export DEBUGINFOD_URLS=https://debuginfod.fedoraproject.org/ > If so, maybe should use more general description for missing DSO. > >> https://fedoraproject.org/wiki/Debuginfod >> >>> With this improvement, the patch looks good to me: >>> >>> Reviewed-by: Leo Yan <leo.yan@linaro.org> >> Does this apply to the other 5 patches in this series? > I finished to reivew patches 01, 04, 05, 06/06, so my review tag can > apply on these patches. Current patch 06/06 needs James to improve for > the comments. Thanks for the reviews, I've submitted v2. I also had a play around with debuginfod, it looks promising. Especially if it's integrated with perf report, which I assume is the plan? Thanks James
Em Thu, Aug 05, 2021 at 01:59:49PM +0100, James Clark escreveu: > > > On 03/08/2021 15:01, Leo Yan wrote: > >> one can also use debuginfod-client, which, as time passes, probably will > >> be the main way of finding DSOs now that we have build-ids in > >> PERF_RECORD_MMAP2 and debuginfod servers such as: > >> > >> export DEBUGINFOD_URLS=https://debuginfod.fedoraproject.org/ > > If so, maybe should use more general description for missing DSO. > > > >> https://fedoraproject.org/wiki/Debuginfod > >> > >>> With this improvement, the patch looks good to me: > >>> > >>> Reviewed-by: Leo Yan <leo.yan@linaro.org> > >> Does this apply to the other 5 patches in this series? > > I finished to reivew patches 01, 04, 05, 06/06, so my review tag can > > apply on these patches. Current patch 06/06 needs James to improve for > > the comments. > > Thanks for the reviews, I've submitted v2. > > I also had a play around with debuginfod, it looks promising. > Especially if it's integrated with perf report, which I assume is the plan? Yeah, code is needed for that in the underlying symbols library so that we can tune its usage, i.e. the threshold of samples to trigger asking for the auto-download of debuginfo files. - Arnaldo
diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c index 32ad92d3e454..e6851260d059 100644 --- a/tools/perf/util/cs-etm.c +++ b/tools/perf/util/cs-etm.c @@ -746,8 +746,16 @@ static u32 cs_etm__mem_access(struct cs_etm_queue *etmq, u8 trace_chan_id, len = dso__data_read_offset(al.map->dso, machine, offset, buffer, size); - if (len <= 0) + if (len <= 0) { + ui__warning_once("CS ETM Trace: Missing DSO. Use 'perf archive' to export data from the traced system.\n"); + if (!al.map->dso->auxtrace_warned) { + pr_err("CS ETM Trace: Debug data not found for address %#"PRIx64" in %s\n", + address, + al.map->dso->long_name ? al.map->dso->long_name : "Unknown"); + al.map->dso->auxtrace_warned = true; + } return 0; + } return len; }
Currently decode will silently fail if no binary data is available for the decode. This is made worse if only partial data is available because the decode will appear to work, but any trace from that missing DSO will silently not be generated. Add a UI popup once if there is any data missing, and then warn in the bottom left for each individual DSO that's missing. Signed-off-by: James Clark <james.clark@arm.com> --- tools/perf/util/cs-etm.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)