mbox series

[v2,0/2] staging: vchiq: Fixups to Kconfig

Message ID cover.1627925241.git.ojaswin98@gmail.com (mailing list archive)
Headers show
Series staging: vchiq: Fixups to Kconfig | expand

Message

Ojaswin Mujoo Aug. 2, 2021, 5:42 p.m. UTC
Hi everyone,

This patchset performs some minor fixups to the config options defined in
/staging/vc04_services/Kconfig. 

Summary of the patches:

Patch 1: Makes BCM2835_VCHIQ imply VCHIQ_CDEV to make the behavior more
         compatible to how it was before VCHIQ_CDEV was introduced (in
         [1]).
Patch 2: Add some more details to the configs' help texts


Changes since v1 [2]:

*  As pre discussion with Greg and Stefan, used "imply" in BCM2835_VCHIQ
   instead of "default y" in VCHIQ_CDEV.
*  Added some more info in help texts of both the config options.

In patch 2, although the resources on VideoCore and vchiq are really
scattered around the internet, I've tried to keep the help text as
accurate as possible, as per my knowledge.
Please do let me know if anything is off in it and I'll fix it.

Thank you!
Ojaswin

[1]
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/patch/?id=2b5930fb3dc06d86149071f9dc8b6992cac1c3aa

[2] https://lore.kernel.org/patchwork/cover/1469192/

Ojaswin Mujoo (2):
  staging: vchiq: Set $CONFIG_BCM2835_VCHIQ to imply $CONFIG_VCHIQ_CDEV
  staging: vchiq: Add details to Kconfig help texts

 drivers/staging/vc04_services/Kconfig | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

Comments

Stefan Wahren Aug. 8, 2021, 7:45 a.m. UTC | #1
Am 02.08.21 um 19:42 schrieb Ojaswin Mujoo:
> Hi everyone,
>
> This patchset performs some minor fixups to the config options defined in
> /staging/vc04_services/Kconfig. 
>
> Summary of the patches:
>
> Patch 1: Makes BCM2835_VCHIQ imply VCHIQ_CDEV to make the behavior more
>          compatible to how it was before VCHIQ_CDEV was introduced (in
>          [1]).
> Patch 2: Add some more details to the configs' help texts
>
>
> Changes since v1 [2]:
>
> *  As pre discussion with Greg and Stefan, used "imply" in BCM2835_VCHIQ
>    instead of "default y" in VCHIQ_CDEV.
> *  Added some more info in help texts of both the config options.
>
> In patch 2, although the resources on VideoCore and vchiq are really
> scattered around the internet, I've tried to keep the help text as
> accurate as possible, as per my knowledge.
> Please do let me know if anything is off in it and I'll fix it.

The whole series is:

Reviewed-by: Stefan Wahren <stefan.wahren@i2se.com>

Thanks