mbox series

[“PATCH”,0/2] Add support for Intel Thunder Bay SPI

Message ID 20210722053358.29682-1-nandhini.srikandan@intel.com (mailing list archive)
Headers show
Series Add support for Intel Thunder Bay SPI | expand

Message

Srikandan, Nandhini July 22, 2021, 5:33 a.m. UTC
From: Nandhini Srikandan <nandhini.srikandan@intel.com>

Hi,

This patch set enables the support for Designware SPI on the Intel Thunder Bay SoC.

Patch 1: SPI DT bindings for Intel Thunder Bay SoC
Patch 2: Adds support for Designware SPI on Intel Thunderbay SoC

Please help to review this patch set.

Thanks & Regards,
Nandhini

Nandhini Srikandan (2):
  dt-bindings: spi: Add bindings for Intel Thunder Bay SoC
  spi: dw: Add support for Intel Thunder Bay SPI

 .../bindings/spi/snps,dw-apb-ssi.yaml         |  2 ++
 drivers/spi/spi-dw-core.c                     |  6 ++++++
 drivers/spi/spi-dw-mmio.c                     | 20 +++++++++++++++++++
 drivers/spi/spi-dw.h                          | 15 ++++++++++++++
 4 files changed, 43 insertions(+)

Comments

Serge Semin July 22, 2021, 4:09 p.m. UTC | #1
Hello Nandhini

On Thu, Jul 22, 2021 at 01:33:56PM +0800, nandhini.srikandan@intel.com wrote:
> From: Nandhini Srikandan <nandhini.srikandan@intel.com>
> 
> Hi,
> 
> This patch set enables the support for Designware SPI on the Intel Thunder Bay SoC.
> 
> Patch 1: SPI DT bindings for Intel Thunder Bay SoC
> Patch 2: Adds support for Designware SPI on Intel Thunderbay SoC
> 
> Please help to review this patch set.

Thanks for the patchset. I'll send you my comments to the
corresponding patches soon.

Regards,
-Sergey

> 
> Thanks & Regards,
> Nandhini
> 
> Nandhini Srikandan (2):
>   dt-bindings: spi: Add bindings for Intel Thunder Bay SoC
>   spi: dw: Add support for Intel Thunder Bay SPI
> 
>  .../bindings/spi/snps,dw-apb-ssi.yaml         |  2 ++
>  drivers/spi/spi-dw-core.c                     |  6 ++++++
>  drivers/spi/spi-dw-mmio.c                     | 20 +++++++++++++++++++
>  drivers/spi/spi-dw.h                          | 15 ++++++++++++++
>  4 files changed, 43 insertions(+)
> 
> -- 
> 2.17.1
>
Serge Semin July 22, 2021, 5:07 p.m. UTC | #2
BTW it's a first time I've met quotes around the PATCH word in the
subject:
[“PATCH” 0/2] Add support for Intel Thunder Bay SPI
 ^     ^

could you drop them?

Regards,
-Serge

On Thu, Jul 22, 2021 at 01:33:56PM +0800, nandhini.srikandan@intel.com wrote:
> From: Nandhini Srikandan <nandhini.srikandan@intel.com>
> 
> Hi,
> 
> This patch set enables the support for Designware SPI on the Intel Thunder Bay SoC.
> 
> Patch 1: SPI DT bindings for Intel Thunder Bay SoC
> Patch 2: Adds support for Designware SPI on Intel Thunderbay SoC
> 
> Please help to review this patch set.
> 
> Thanks & Regards,
> Nandhini
> 
> Nandhini Srikandan (2):
>   dt-bindings: spi: Add bindings for Intel Thunder Bay SoC
>   spi: dw: Add support for Intel Thunder Bay SPI
> 
>  .../bindings/spi/snps,dw-apb-ssi.yaml         |  2 ++
>  drivers/spi/spi-dw-core.c                     |  6 ++++++
>  drivers/spi/spi-dw-mmio.c                     | 20 +++++++++++++++++++
>  drivers/spi/spi-dw.h                          | 15 ++++++++++++++
>  4 files changed, 43 insertions(+)
> 
> -- 
> 2.17.1
>
Srikandan, Nandhini Aug. 10, 2021, 9:24 a.m. UTC | #3
> -----Original Message-----
> From: Serge Semin <fancer.lancer@gmail.com>
> Sent: Thursday, July 22, 2021 9:39 PM
> To: Srikandan, Nandhini <nandhini.srikandan@intel.com>
> Cc: broonie@kernel.org; robh+dt@kernel.org; linux-spi@vger.kernel.org;
> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org;
> mgross@linux.intel.com; Pan, Kris <kris.pan@intel.com>; Demakkanavar,
> Kenchappa <kenchappa.demakkanavar@intel.com>; Zhou, Furong
> <furong.zhou@intel.com>; Sangannavar, Mallikarjunappa
> <mallikarjunappa.sangannavar@intel.com>; Vaidya, Mahesh R
> <mahesh.r.vaidya@intel.com>; A, Rashmi <rashmi.a@intel.com>
> Subject: Re: [“PATCH” 0/2] Add support for Intel Thunder Bay SPI
> 
> Hello Nandhini
> 
> On Thu, Jul 22, 2021 at 01:33:56PM +0800, nandhini.srikandan@intel.com
> wrote:
> > From: Nandhini Srikandan <nandhini.srikandan@intel.com>
> >
> > Hi,
> >
> > This patch set enables the support for Designware SPI on the Intel Thunder
> Bay SoC.
> >
> > Patch 1: SPI DT bindings for Intel Thunder Bay SoC Patch 2: Adds
> > support for Designware SPI on Intel Thunderbay SoC
> >
> > Please help to review this patch set.
> 
> Thanks for the patchset. I'll send you my comments to the corresponding
> patches soon.
> 
Thank you for your review comments. I am working on it and I will share another patchset shortly. 

Regards,
Nandhini

> >
> > Thanks & Regards,
> > Nandhini
> >
> > Nandhini Srikandan (2):
> >   dt-bindings: spi: Add bindings for Intel Thunder Bay SoC
> >   spi: dw: Add support for Intel Thunder Bay SPI
> >
> >  .../bindings/spi/snps,dw-apb-ssi.yaml         |  2 ++
> >  drivers/spi/spi-dw-core.c                     |  6 ++++++
> >  drivers/spi/spi-dw-mmio.c                     | 20 +++++++++++++++++++
> >  drivers/spi/spi-dw.h                          | 15 ++++++++++++++
> >  4 files changed, 43 insertions(+)
> >
> > --
> > 2.17.1
> >
Serge Semin Aug. 10, 2021, 9:52 a.m. UTC | #4
On Tue, Aug 10, 2021 at 09:24:08AM +0000, Srikandan, Nandhini wrote:
> 
> 
> > -----Original Message-----
> > From: Serge Semin <fancer.lancer@gmail.com>
> > Sent: Thursday, July 22, 2021 9:39 PM
> > To: Srikandan, Nandhini <nandhini.srikandan@intel.com>
> > Cc: broonie@kernel.org; robh+dt@kernel.org; linux-spi@vger.kernel.org;
> > linux-kernel@vger.kernel.org; devicetree@vger.kernel.org;
> > mgross@linux.intel.com; Pan, Kris <kris.pan@intel.com>; Demakkanavar,
> > Kenchappa <kenchappa.demakkanavar@intel.com>; Zhou, Furong
> > <furong.zhou@intel.com>; Sangannavar, Mallikarjunappa
> > <mallikarjunappa.sangannavar@intel.com>; Vaidya, Mahesh R
> > <mahesh.r.vaidya@intel.com>; A, Rashmi <rashmi.a@intel.com>
> > Subject: Re: [“PATCH” 0/2] Add support for Intel Thunder Bay SPI
> > 
> > Hello Nandhini
> > 
> > On Thu, Jul 22, 2021 at 01:33:56PM +0800, nandhini.srikandan@intel.com
> > wrote:
> > > From: Nandhini Srikandan <nandhini.srikandan@intel.com>
> > >
> > > Hi,
> > >
> > > This patch set enables the support for Designware SPI on the Intel Thunder
> > Bay SoC.
> > >
> > > Patch 1: SPI DT bindings for Intel Thunder Bay SoC Patch 2: Adds
> > > support for Designware SPI on Intel Thunderbay SoC
> > >
> > > Please help to review this patch set.
> > 
> > Thanks for the patchset. I'll send you my comments to the corresponding
> > patches soon.
> > 

> Thank you for your review comments. I am working on it and I will share another patchset shortly. 

I'd suggest to answer on the review questions first...

-Sergey

> 
> Regards,
> Nandhini
> 
> > >
> > > Thanks & Regards,
> > > Nandhini
> > >
> > > Nandhini Srikandan (2):
> > >   dt-bindings: spi: Add bindings for Intel Thunder Bay SoC
> > >   spi: dw: Add support for Intel Thunder Bay SPI
> > >
> > >  .../bindings/spi/snps,dw-apb-ssi.yaml         |  2 ++
> > >  drivers/spi/spi-dw-core.c                     |  6 ++++++
> > >  drivers/spi/spi-dw-mmio.c                     | 20 +++++++++++++++++++
> > >  drivers/spi/spi-dw.h                          | 15 ++++++++++++++
> > >  4 files changed, 43 insertions(+)
> > >
> > > --
> > > 2.17.1
> > >