| Message ID | 20110901130930.5caec2d4@jbarnes-desktop (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Thu, Sep 01, 2011 at 01:09:30PM -0700, Jesse Barnes wrote: > On Thu, 1 Sep 2011 15:03:49 -0500 > scameron@beardog.cce.hp.com wrote: > > > On Thu, Sep 01, 2011 at 12:59:38PM -0700, Jesse Barnes wrote: > > > On Thu, 01 Sep 2011 11:50:38 -0700 > > > James Bottomley <James.Bottomley@HansenPartnership.com> wrote: > > > > > > > On Thu, 2011-09-01 at 10:58 -0700, Roland Dreier wrote: > > > > > > OK I found the bad commit,I got lucky... I lost some files but my > > > > > > machine was able to complete the bisection. CC involved people > > > > > > > > > > > # bad: [b03e7495a862b028294f59fc87286d6d78ee7fa1] PCI: Set PCI-E Max Payload Size on fabric > > > > > > > > > > Hi Eric, > > > > > > > > > > I guess it would be useful to see "lspci -vv" output with a "good" kernel > > > > > and with that bad patch applied. Most likely we should see some difference > > > > > somewhere in the MaxPayload fields in the PCI Express capability of > > > > > some device. > > > > > > > > > > Either the RAID controller or something else lies, and puts a value > > > > > in the DevCap that it can't actually support, or else the patch is > > > > > buggy and puts something out of range in a DevCtl somewhere. > > > > > > > > > > > > While we investigate, I think the problems produced by the patch (data > > > > corruption) are serious enough to warrant reverting it, please Jesse. > > > > > > Hm I haven't been paying attention to the compromise thread; how should > > > I share these changes? Is master.kernel.org down indefinitely? Is > > > there a new server at kernel.org I can use? > > > > I can't answer that question, but I would like a copy of your revert > > patch(es) to test (as a simple patch --reverse of the original commit on the 3.1-rc4 > > tree didn't go in cleanly). > > Attached is the series. Applies on top of my for-linus branch. Thanks. I tried them out vs. 3.1-rc4, and they applied cleanly and make things work on my BL460g7. -- steve -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From 7ec72e08c43fbf698e62eac1d509cfe8238c0b25 Mon Sep 17 00:00:00 2001 From: Jesse Barnes <jbarnes@virtuousgeek.org> Date: Thu, 1 Sep 2011 12:32:55 -0700 Subject: [PATCH 1/3] PCI: Revert "pci: fix new kernel-doc warning in pci.c" This reverts commit 47c08f3107270e5a439bc0106a308f7c48c9621d, a comment fix up for the next revert. Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> --- drivers/pci/pci.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 0ce6742..466fad6 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -3250,7 +3250,7 @@ int pcie_get_mps(struct pci_dev *dev) /** * pcie_set_mps - set PCI Express maximum payload size * @dev: PCI device to query - * @mps: maximum payload size in bytes + * @rq: maximum payload size in bytes * valid values are 128, 256, 512, 1024, 2048, 4096 * * If possible sets maximum payload size -- 1.7.1