| Message ID | 20210817091456.73342-3-hare@suse.de (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | SCSI EH argument reshuffle part II | expand |
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
On 8/17/2021 2:14 AM, Hannes Reinecke wrote: > The default SCSI EH action for a non-existing EH callback is to > return FAILED, so having a callback just returning FAILED is pointless. > > Signed-off-by: Hannes Reinecke <hare@suse.de> > Cc: James Smart <james.smart@broadcom.com> > --- > drivers/scsi/lpfc/lpfc_scsi.c | 10 ---------- > 1 file changed, 10 deletions(-) > Looks good Reviewed-by: James Smart <jsmart2021@gmail.com> -- james
diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index 56ccc66d3d5f..48b932608ffb 100644 --- a/drivers/scsi/lpfc/lpfc_scsi.c +++ b/drivers/scsi/lpfc/lpfc_scsi.c @@ -6925,12 +6925,6 @@ lpfc_no_command(struct Scsi_Host *shost, struct scsi_cmnd *cmnd) return SCSI_MLQUEUE_HOST_BUSY; } -static int -lpfc_no_handler(struct scsi_cmnd *cmnd) -{ - return FAILED; -} - static int lpfc_no_slave(struct scsi_device *sdev) { @@ -6943,10 +6937,6 @@ struct scsi_host_template lpfc_template_nvme = { .proc_name = LPFC_DRIVER_NAME, .info = lpfc_info, .queuecommand = lpfc_no_command, - .eh_abort_handler = lpfc_no_handler, - .eh_device_reset_handler = lpfc_no_handler, - .eh_target_reset_handler = lpfc_no_handler, - .eh_host_reset_handler = lpfc_no_handler, .slave_alloc = lpfc_no_slave, .slave_configure = lpfc_no_slave, .scan_finished = lpfc_scan_finished,
The default SCSI EH action for a non-existing EH callback is to return FAILED, so having a callback just returning FAILED is pointless. Signed-off-by: Hannes Reinecke <hare@suse.de> Cc: James Smart <james.smart@broadcom.com> --- drivers/scsi/lpfc/lpfc_scsi.c | 10 ---------- 1 file changed, 10 deletions(-)