| Message ID | 771d94cf-5e82-0cb7-fb1f-5af2f0b10dd4@omp.ru (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Correctly handle plaform_get_irq()'s result in the i2C drivers | expand |
On 04/07/2021 16:45, Sergey Shtylyov wrote: > Iff platform_get_irq() returns 0, the driver's probe() method will return 0 > early (as if the method's call was successful). Let's consider IRQ0 valid > for simplicity -- devm_request_irq() can always override that decision... > > Fixes: 2bbd681ba2b ("i2c-s3c2410: Change IRQ to be plain integer.") > Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> > > --- > drivers/i2c/busses/i2c-s3c2410.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
On Sun, Jul 04, 2021 at 05:45:25PM +0300, Sergey Shtylyov wrote: > Iff platform_get_irq() returns 0, the driver's probe() method will return 0 > early (as if the method's call was successful). Let's consider IRQ0 valid > for simplicity -- devm_request_irq() can always override that decision... > > Fixes: 2bbd681ba2b ("i2c-s3c2410: Change IRQ to be plain integer.") > Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> > Applied to for-next, thanks!
Index: linux/drivers/i2c/busses/i2c-s3c2410.c =================================================================== --- linux.orig/drivers/i2c/busses/i2c-s3c2410.c +++ linux/drivers/i2c/busses/i2c-s3c2410.c @@ -1137,7 +1137,7 @@ static int s3c24xx_i2c_probe(struct plat */ if (!(i2c->quirks & QUIRK_POLL)) { i2c->irq = ret = platform_get_irq(pdev, 0); - if (ret <= 0) { + if (ret < 0) { dev_err(&pdev->dev, "cannot find IRQ\n"); clk_unprepare(i2c->clk); return ret;
Iff platform_get_irq() returns 0, the driver's probe() method will return 0 early (as if the method's call was successful). Let's consider IRQ0 valid for simplicity -- devm_request_irq() can always override that decision... Fixes: 2bbd681ba2b ("i2c-s3c2410: Change IRQ to be plain integer.") Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> --- drivers/i2c/busses/i2c-s3c2410.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)