| Message ID | 20210818092741.2114155-2-sean@geanix.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] iio: accel: fxls8962af: add threshold event handling | expand |
On Wed, Aug 18, 2021 at 12:29 PM Sean Nyekjaer <sean@geanix.com> wrote: > > This add ways for the SoC to wake from accelerometer wake events. adds > In the suspend function we skip disabling the sensor if wakeup-source > and events are activated. > If the buffer is enabled it will be deactivated before suspend, as the > buffer is quite small. "..., because it is..." Or what are you saying here? ... > + if (dev_fwnode(dev) && device_property_read_bool(dev, "wakeup-source")) dev_fwnode() is redundant. > + device_init_wakeup(dev, true); ... > +static int __maybe_unused fxls8962af_suspend(struct device *dev) > +{ > + struct iio_dev *indio_dev = dev_get_drvdata(dev); > + struct fxls8962af_data *data = iio_priv(indio_dev); > + > + One blank line is enough. > + if (device_may_wakeup(dev) && data->enable_event) { > + enable_irq_wake(data->irq); > + > + /* > + * Disable buffer, as the buffer is so small the device will wake > + * almost immediately. > + */ > + if (iio_buffer_enabled(indio_dev)) > + fxls8962af_buffer_predisable(indio_dev); > + } else { > + fxls8962af_runtime_suspend(dev); > + } > + > + return 0; > +}
On Wed, Aug 18, 2021 at 11:27:41AM +0200, Sean Nyekjaer wrote: > This add ways for the SoC to wake from accelerometer wake events. > > In the suspend function we skip disabling the sensor if wakeup-source > and events are activated. > If the buffer is enabled it will be deactivated before suspend, as the > buffer is quite small. > > Signed-off-by: Sean Nyekjaer <sean@geanix.com> I notice when using IRQ_TYPE_LEVEL_LOW, the IRQ will loop on resume until wdg is restarting the system. If I use IRQ_TYPE_EDGE_FALLING it will only fail once with -13 EACCES. Maybe I2C isn't up and running when it tries to handle the irq. /Sean
diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c index 1b97c82b5b05..60d50759de12 100644 --- a/drivers/iio/accel/fxls8962af-core.c +++ b/drivers/iio/accel/fxls8962af-core.c @@ -160,6 +160,7 @@ struct fxls8962af_data { } scan; int64_t timestamp, old_timestamp; /* Only used in hw fifo mode. */ struct iio_mount_matrix orientation; + int irq; u8 watermark; u8 enable_event; u16 lower_thres; @@ -1114,6 +1115,7 @@ int fxls8962af_core_probe(struct device *dev, struct regmap *regmap, int irq) data = iio_priv(indio_dev); dev_set_drvdata(dev, indio_dev); data->regmap = regmap; + data->irq = irq; ret = iio_read_mount_matrix(dev, &data->orientation); if (ret) @@ -1183,6 +1185,9 @@ int fxls8962af_core_probe(struct device *dev, struct regmap *regmap, int irq) if (ret) return ret; + if (dev_fwnode(dev) && device_property_read_bool(dev, "wakeup-source")) + device_init_wakeup(dev, true); + return devm_iio_device_register(dev, indio_dev); } EXPORT_SYMBOL_GPL(fxls8962af_core_probe); @@ -1208,9 +1213,48 @@ static int __maybe_unused fxls8962af_runtime_resume(struct device *dev) return fxls8962af_active(data); } +static int __maybe_unused fxls8962af_suspend(struct device *dev) +{ + struct iio_dev *indio_dev = dev_get_drvdata(dev); + struct fxls8962af_data *data = iio_priv(indio_dev); + + + if (device_may_wakeup(dev) && data->enable_event) { + enable_irq_wake(data->irq); + + /* + * Disable buffer, as the buffer is so small the device will wake + * almost immediately. + */ + if (iio_buffer_enabled(indio_dev)) + fxls8962af_buffer_predisable(indio_dev); + } else { + fxls8962af_runtime_suspend(dev); + } + + return 0; +} + +static int __maybe_unused fxls8962af_resume(struct device *dev) +{ + struct iio_dev *indio_dev = dev_get_drvdata(dev); + struct fxls8962af_data *data = iio_priv(indio_dev); + + if (device_may_wakeup(dev) && data->enable_event) { + disable_irq_wake(data->irq); + + if (iio_buffer_enabled(indio_dev)) + fxls8962af_buffer_postenable(indio_dev); + } else { + fxls8962af_runtime_resume(dev); + } + + return 0; +} + const struct dev_pm_ops fxls8962af_pm_ops = { - SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, - pm_runtime_force_resume) + SET_SYSTEM_SLEEP_PM_OPS(fxls8962af_suspend, + fxls8962af_resume) SET_RUNTIME_PM_OPS(fxls8962af_runtime_suspend, fxls8962af_runtime_resume, NULL) };
This add ways for the SoC to wake from accelerometer wake events. In the suspend function we skip disabling the sensor if wakeup-source and events are activated. If the buffer is enabled it will be deactivated before suspend, as the buffer is quite small. Signed-off-by: Sean Nyekjaer <sean@geanix.com> --- drivers/iio/accel/fxls8962af-core.c | 48 +++++++++++++++++++++++++++-- 1 file changed, 46 insertions(+), 2 deletions(-)