| Message ID | 9a57c9f837fa2c6f0070578a1bc4840688f62962.1628185335.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | RDMA/rtrs: Remove a useless kfree | expand |
On Thu, Aug 5, 2021 at 7:43 PM Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > > 'sess->rbufs' is known to be NULL here, so there is no point in kfree'ing > it. It is just a no-op. > > Remove the useless kfree. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Thanks Acked-by: Md Haris Iqbal <haris.iqbal@ionos.com> > --- > drivers/infiniband/ulp/rtrs/rtrs-clt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c > index ece3205531b8..fc440a08e112 100644 > --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c > +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c > @@ -1844,7 +1844,6 @@ static int rtrs_rdma_conn_established(struct rtrs_clt_con *con, > } > > if (!sess->rbufs) { > - kfree(sess->rbufs); > sess->rbufs = kcalloc(queue_depth, sizeof(*sess->rbufs), > GFP_KERNEL); > if (!sess->rbufs) > -- > 2.30.2 >
On Thu, Aug 05, 2021 at 07:43:36PM +0200, Christophe JAILLET wrote: > 'sess->rbufs' is known to be NULL here, so there is no point in kfree'ing > it. It is just a no-op. > > Remove the useless kfree. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > Acked-by: Md Haris Iqbal <haris.iqbal@ionos.com> > --- > drivers/infiniband/ulp/rtrs/rtrs-clt.c | 1 - > 1 file changed, 1 deletion(-) Applied to for-next with a Fixes line, thanks Jason
diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c index ece3205531b8..fc440a08e112 100644 --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c @@ -1844,7 +1844,6 @@ static int rtrs_rdma_conn_established(struct rtrs_clt_con *con, } if (!sess->rbufs) { - kfree(sess->rbufs); sess->rbufs = kcalloc(queue_depth, sizeof(*sess->rbufs), GFP_KERNEL); if (!sess->rbufs)
'sess->rbufs' is known to be NULL here, so there is no point in kfree'ing it. It is just a no-op. Remove the useless kfree. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/infiniband/ulp/rtrs/rtrs-clt.c | 1 - 1 file changed, 1 deletion(-)