| Message ID | 20210730165110.24667-1-novikov@ispras.ru (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | d0f1d5ae23803bd82647a337fa508fa8615defc5 |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | [1/3] HID: thrustmaster: Fix memory leaks in probe | expand |
On Fri, 30 Jul 2021, Evgeny Novikov wrote: > When thrustmaster_probe() handles errors of usb_submit_urb() it does not > free allocated resources and fails. The patch fixes that. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Evgeny Novikov <novikov@ispras.ru> I've applied all three fixes, thanks.
diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c index cdc7d82ae9ed..e94d3409fd10 100644 --- a/drivers/hid/hid-thrustmaster.c +++ b/drivers/hid/hid-thrustmaster.c @@ -336,11 +336,14 @@ static int thrustmaster_probe(struct hid_device *hdev, const struct hid_device_i ); ret = usb_submit_urb(tm_wheel->urb, GFP_ATOMIC); - if (ret) + if (ret) { hid_err(hdev, "Error %d while submitting the URB. I am unable to initialize this wheel...\n", ret); + goto error6; + } return ret; +error6: kfree(tm_wheel->change_request); error5: kfree(tm_wheel->response); error4: kfree(tm_wheel->model_request); error3: usb_free_urb(tm_wheel->urb);
When thrustmaster_probe() handles errors of usb_submit_urb() it does not free allocated resources and fails. The patch fixes that. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Evgeny Novikov <novikov@ispras.ru> --- drivers/hid/hid-thrustmaster.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)