[v2,0/2] drm/i915, drm/ttm: Update the ttm_move_memcpy() interface

Message

Thomas Hellstrom Aug. 13, 2021, 2:43 p.m. UTC

The ttm_move_memcpy() function was intended to be able to be used async
under a fence.
We are going to utilize that as a fallback if the gpu clearing blit fails
before we set up CPU- or GPU ptes to the memory region.
But to accomplish that the bo argument to ttm_move_memcpy() needs to be
replaced.

Patch 1 reorganizes the i915 ttm move code a bit to make the change
in patch 2 smaller.
Patch 2 updates the ttm_move_memcpy() interface.

v2:
- Don't initialize memcpy iterators until they are actually needed (Patch 1).
- Added proper R-B:s and Cc:s

Thomas Hellström (2):
  drm/i915/ttm: Reorganize the ttm move code somewhat
  drm/ttm, drm/i915: Update ttm_move_memcpy for async use

 drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 77 ++++++++++++++-----------
 drivers/gpu/drm/ttm/ttm_bo_util.c       | 20 +++----
 include/drm/ttm/ttm_bo_driver.h         |  2 +-
 3 files changed, 55 insertions(+), 44 deletions(-)

Cc: Christian König <[e-mail]>

Comments

Thomas Hellstrom Aug. 23, 2021, 7:07 a.m. UTC | #1

On Fri, 2021-08-13 at 20:28 +0000, Patchwork wrote:
> Patch Details
> Series:drm/i915, drm/ttm: Update the ttm_move_memcpy() interface
> (rev3)URL:
> https://patchwork.freedesktop.org/series/91893/State:failure
> Details:https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20819/index.html
> CI Bug Log - changes from CI_DRM_10482_full -> Patchwork_20819_fullSummaryFAILURE
> Serious unknown changes coming with Patchwork_20819_full absolutely
> need to be
> verified manually.
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_20819_full, please notify your bug team to
> allow them
> to document this new failure mode, which will reduce false positives
> in CI.
> Possible new issuesHere are the unknown changes that may have been introduced in
> Patchwork_20819_full:
> IGT changesPossible regressions * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
>     - shard-glk: PASS -> FAIL

Lakshmi, this failure is unrelated.

Thanks,
Thomas

Vudum, Lakshminarayana Aug. 23, 2021, 3:38 p.m. UTC | #2

Re-reported.

Lakshmi.

From: Thomas Hellström <[e-mail]>
Sent: Monday, August 23, 2021 12:07 AM
To: [e-mail]; Vudum, Lakshminarayana <[e-mail]>
Subject: Re: ✗ Fi.CI.IGT: failure for drm/i915, drm/ttm: Update the ttm_move_memcpy() interface (rev3)

On Fri, 2021-08-13 at 20:28 +0000, Patchwork wrote:
Patch Details
Series:

drm/i915, drm/ttm: Update the ttm_move_memcpy() interface (rev3)

URL:

https://patchwork.freedesktop.org/series/91893/

State:

failure

Details:

https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20819/index.html

CI Bug Log - changes from CI_DRM_10482_full -> Patchwork_20819_full
Summary

FAILURE

Serious unknown changes coming with Patchwork_20819_full absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_20819_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_20819_full:

IGT changes
Possible regressions

  *   igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-glk8/igt@[e-mail]> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20819/shard-glk5/igt@[e-mail]>

Lakshmi, this failure is unrelated.

Thanks,
Thomas