| Message ID | 20210819182544.224121-2-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [1/2] dt-bindings: hwmon: merge max1619 into trivial devices | expand |
On 8/19/21 11:25 AM, Krzysztof Kozlowski wrote: > Ther Maxim max31785 bindings are trivial, so simply merge it into > trivial-devices.yaml. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > .../devicetree/bindings/hwmon/max31785.txt | 22 ------------------- Not sure if that is a good idea. It would make more sense to standardize the properties needed by the driver/chip instead (see existing dts files in the kernel). Guenter
On Fri, Aug 20, 2021 at 9:23 AM Guenter Roeck <linux@roeck-us.net> wrote: > > On 8/19/21 11:25 AM, Krzysztof Kozlowski wrote: > > Ther Maxim max31785 bindings are trivial, so simply merge it into > > trivial-devices.yaml. > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > > --- > > .../devicetree/bindings/hwmon/max31785.txt | 22 ------------------- > > Not sure if that is a good idea. It would make more sense to standardize the > properties needed by the driver/chip instead (see existing dts files in the kernel). This device is certainly not trivial, the binding is just incomplete. Device specific fan controller bindings are something I'm just going to reject until someone comes up with something common. Rob
diff --git a/Documentation/devicetree/bindings/hwmon/max31785.txt b/Documentation/devicetree/bindings/hwmon/max31785.txt deleted file mode 100644 index 106e08c56aaa..000000000000 --- a/Documentation/devicetree/bindings/hwmon/max31785.txt +++ /dev/null @@ -1,22 +0,0 @@ -Bindings for the Maxim MAX31785 Intelligent Fan Controller -========================================================== - -Reference: - -https://datasheets.maximintegrated.com/en/ds/MAX31785.pdf - -The Maxim MAX31785 is a PMBus device providing closed-loop, multi-channel fan -management with temperature and remote voltage sensing. Various fan control -features are provided, including PWM frequency control, temperature hysteresis, -dual tachometer measurements, and fan health monitoring. - -Required properties: -- compatible : One of "maxim,max31785" or "maxim,max31785a" -- reg : I2C address, one of 0x52, 0x53, 0x54, 0x55. - -Example: - - fans@52 { - compatible = "maxim,max31785"; - reg = <0x52>; - }; diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 1e4b3464d734..646ab3a82387 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -163,6 +163,10 @@ properties: - maxim,max6625 # 3-Channel Remote Temperature Sensor - maxim,max31730 + # Intelligent Fan Controller with temperature and remote voltage sensing + # Datasheet: https://datasheets.maximintegrated.com/en/ds/MAX31785.pdf + - maxim,max31785 + - maxim,max31785a # mCube 3-axis 8-bit digital accelerometer - mcube,mc3230 # Measurement Specialities I2C temperature and humidity sensor diff --git a/MAINTAINERS b/MAINTAINERS index fda9f438cc27..c8935b455dd2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14869,7 +14869,6 @@ W: http://www.roeck-us.net/linux/drivers/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git F: Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt F: Documentation/devicetree/bindings/hwmon/ltc2978.txt -F: Documentation/devicetree/bindings/hwmon/max31785.txt F: Documentation/hwmon/adm1275.rst F: Documentation/hwmon/ibm-cffps.rst F: Documentation/hwmon/ir35221.rst
Ther Maxim max31785 bindings are trivial, so simply merge it into trivial-devices.yaml. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- .../devicetree/bindings/hwmon/max31785.txt | 22 ------------------- .../devicetree/bindings/trivial-devices.yaml | 4 ++++ MAINTAINERS | 1 - 3 files changed, 4 insertions(+), 23 deletions(-) delete mode 100644 Documentation/devicetree/bindings/hwmon/max31785.txt