| Message ID | 20210824030550.57467-1-deng.changcheng@zte.com.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6af0b5570b59ce8dd1608a8e48f59eff3f4bdd04 |
| Headers | show |
| Series | [linux-next] selftests/powerpc: remove duplicate include | expand |
On 8/23/21 9:05 PM, CGEL wrote: > From: Changcheng Deng <deng.changcheng@zte.com.cn> > > Clean up the following includecheck warning: > > ./tools/testing/selftests/powerpc/tm/tm-poison.c: inttypes.h is included > more than once. > > No functional change. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn> > --- > tools/testing/selftests/powerpc/tm/tm-poison.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c b/tools/testing/selftests/powerpc/tm/tm-poison.c > index 29e5f26..27c083a 100644 > --- a/tools/testing/selftests/powerpc/tm/tm-poison.c > +++ b/tools/testing/selftests/powerpc/tm/tm-poison.c > @@ -20,7 +20,6 @@ > #include <sched.h> > #include <sys/types.h> > #include <signal.h> > -#include <inttypes.h> > > #include "tm.h" > > We can't accept this patch. The from and Signed-off-by don't match. thanks, -- Shuah
Le 24/08/2021 à 16:41, Shuah Khan a écrit : > On 8/23/21 9:05 PM, CGEL wrote: >> From: Changcheng Deng <deng.changcheng@zte.com.cn> >> >> Clean up the following includecheck warning: >> >> ./tools/testing/selftests/powerpc/tm/tm-poison.c: inttypes.h is included >> more than once. >> >> No functional change. >> >> Reported-by: Zeal Robot <zealci@zte.com.cn> >> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn> >> --- >> tools/testing/selftests/powerpc/tm/tm-poison.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c >> b/tools/testing/selftests/powerpc/tm/tm-poison.c >> index 29e5f26..27c083a 100644 >> --- a/tools/testing/selftests/powerpc/tm/tm-poison.c >> +++ b/tools/testing/selftests/powerpc/tm/tm-poison.c >> @@ -20,7 +20,6 @@ >> #include <sched.h> >> #include <sys/types.h> >> #include <signal.h> >> -#include <inttypes.h> >> #include "tm.h" >> > > We can't accept this patch. The from and Signed-off-by don't match. As far as I can see they match: From: Changcheng Deng <deng.changcheng@zte.com.cn> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn> Christophe
On 8/24/21 10:35 AM, Christophe Leroy wrote: > > > Le 24/08/2021 à 16:41, Shuah Khan a écrit : >> On 8/23/21 9:05 PM, CGEL wrote: >>> From: Changcheng Deng <deng.changcheng@zte.com.cn> >>> >>> Clean up the following includecheck warning: >>> >>> ./tools/testing/selftests/powerpc/tm/tm-poison.c: inttypes.h is included >>> more than once. >>> >>> No functional change. >>> >>> Reported-by: Zeal Robot <zealci@zte.com.cn> >>> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn> >>> --- >>> tools/testing/selftests/powerpc/tm/tm-poison.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c b/tools/testing/selftests/powerpc/tm/tm-poison.c >>> index 29e5f26..27c083a 100644 >>> --- a/tools/testing/selftests/powerpc/tm/tm-poison.c >>> +++ b/tools/testing/selftests/powerpc/tm/tm-poison.c >>> @@ -20,7 +20,6 @@ >>> #include <sched.h> >>> #include <sys/types.h> >>> #include <signal.h> >>> -#include <inttypes.h> >>> #include "tm.h" >>> >> >> We can't accept this patch. The from and Signed-off-by don't match. > > As far as I can see they match: > > From: Changcheng Deng <deng.changcheng@zte.com.cn> > Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn> > Yeah. My bad. thanks, -- Shuah
diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c b/tools/testing/selftests/powerpc/tm/tm-poison.c index 29e5f26..27c083a 100644 --- a/tools/testing/selftests/powerpc/tm/tm-poison.c +++ b/tools/testing/selftests/powerpc/tm/tm-poison.c @@ -20,7 +20,6 @@ #include <sched.h> #include <sys/types.h> #include <signal.h> -#include <inttypes.h> #include "tm.h"