| Message ID | 20210825211733.264844-1-jonathan.lemon@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bc8e05d6b9658b6b59cb770d981064244cdc574b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] ptp: ocp: Simplify Kconfig. | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 2 of 2 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 18 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Wed, Aug 25, 2021 at 11:17 PM Jonathan Lemon <jonathan.lemon@gmail.com> wrote: > > Remove the 'imply' statements, these apparently are not doing > what I expected. Platform modules which are used by the driver > still need to be enabled in the overall config for them to be > used, but there isn't a hard dependency on them. > > Use 'depend' for selectable modules which provide functions > used directly by the driver. > > Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com> > --- > drivers/ptp/Kconfig | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) Reviewed-by: Arnd Bergmann <arnd@arndb.de>
On 8/25/21 2:17 PM, Jonathan Lemon wrote: > Remove the 'imply' statements, these apparently are not doing > what I expected. Platform modules which are used by the driver > still need to be enabled in the overall config for them to be > used, but there isn't a hard dependency on them. > > Use 'depend' for selectable modules which provide functions > used directly by the driver. > > Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com> > --- > drivers/ptp/Kconfig | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig > index 32660dc11354..f02bedf41264 100644 > --- a/drivers/ptp/Kconfig > +++ b/drivers/ptp/Kconfig > @@ -171,16 +171,10 @@ config PTP_1588_CLOCK_OCP > tristate "OpenCompute TimeCard as PTP clock" > depends on PTP_1588_CLOCK > depends on HAS_IOMEM && PCI > - depends on SPI && I2C && MTD > + depends on I2C && MTD > + depends on SERIAL_8250 > depends on !S390 > - imply SPI_MEM > - imply SPI_XILINX > - imply MTD_SPI_NOR > - imply I2C_XILINX > - select SERIAL_8250 > select NET_DEVLINK > - > - default n > help > This driver adds support for an OpenCompute time card. > > Reviewed-by: Randy Dunlap <rdunlap@infradead.org> Thanks.
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 25 Aug 2021 14:17:33 -0700 you wrote: > Remove the 'imply' statements, these apparently are not doing > what I expected. Platform modules which are used by the driver > still need to be enabled in the overall config for them to be > used, but there isn't a hard dependency on them. > > Use 'depend' for selectable modules which provide functions > used directly by the driver. > > [...] Here is the summary with links: - [net-next] ptp: ocp: Simplify Kconfig. https://git.kernel.org/netdev/net-next/c/bc8e05d6b965 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig index 32660dc11354..f02bedf41264 100644 --- a/drivers/ptp/Kconfig +++ b/drivers/ptp/Kconfig @@ -171,16 +171,10 @@ config PTP_1588_CLOCK_OCP tristate "OpenCompute TimeCard as PTP clock" depends on PTP_1588_CLOCK depends on HAS_IOMEM && PCI - depends on SPI && I2C && MTD + depends on I2C && MTD + depends on SERIAL_8250 depends on !S390 - imply SPI_MEM - imply SPI_XILINX - imply MTD_SPI_NOR - imply I2C_XILINX - select SERIAL_8250 select NET_DEVLINK - - default n help This driver adds support for an OpenCompute time card.
Remove the 'imply' statements, these apparently are not doing what I expected. Platform modules which are used by the driver still need to be enabled in the overall config for them to be used, but there isn't a hard dependency on them. Use 'depend' for selectable modules which provide functions used directly by the driver. Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com> --- drivers/ptp/Kconfig | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)