| Message ID | 20210209164506.54176-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] efi: Don't use knowledge about efi_guid_t internals | expand |
On Tue, 9 Feb 2021 at 17:45, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather > its internal members. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Ard Biesheuvel <ardb@kernel.org> > --- > security/integrity/platform_certs/efi_parser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/integrity/platform_certs/efi_parser.c b/security/integrity/platform_certs/efi_parser.c > index 18f01f36fe6a..d98260f8402a 100644 > --- a/security/integrity/platform_certs/efi_parser.c > +++ b/security/integrity/platform_certs/efi_parser.c > @@ -55,7 +55,7 @@ int __init parse_efi_signature_list( > memcpy(&list, data, sizeof(list)); > pr_devel("LIST[%04x] guid=%pUl ls=%x hs=%x ss=%x\n", > offs, > - list.signature_type.b, list.signature_list_size, > + &list.signature_type, list.signature_list_size, > list.signature_header_size, list.signature_size); > > lsize = list.signature_list_size; > -- > 2.30.0 >
On Tue, Feb 09, 2021 at 05:51:45PM +0100, Ard Biesheuvel wrote: > On Tue, 9 Feb 2021 at 17:45, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather > > its internal members. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Acked-by: Ard Biesheuvel <ardb@kernel.org> Thanks! Can we get this applied, please?
On Mon, 7 Jun 2021 at 19:11, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Tue, Feb 09, 2021 at 05:51:45PM +0100, Ard Biesheuvel wrote: > > On Tue, 9 Feb 2021 at 17:45, Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: > > > > > > When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather > > > its internal members. > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > Acked-by: Ard Biesheuvel <ardb@kernel.org> > > Thanks! > > Can we get this applied, please? > Apologies, this one slipped behind the desk.
On Thu, Jun 10, 2021 at 05:05:55PM +0200, Ard Biesheuvel wrote: > On Mon, 7 Jun 2021 at 19:11, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Tue, Feb 09, 2021 at 05:51:45PM +0100, Ard Biesheuvel wrote: > > > On Tue, 9 Feb 2021 at 17:45, Andy Shevchenko > > > <andriy.shevchenko@linux.intel.com> wrote: > > > > > > > > When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather > > > > its internal members. > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > > Acked-by: Ard Biesheuvel <ardb@kernel.org> > > > > Thanks! > > > > Can we get this applied, please? > > Apologies, this one slipped behind the desk. Do I need to resend it?
On Thu, 26 Aug 2021 at 17:08, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Thu, Jun 10, 2021 at 05:05:55PM +0200, Ard Biesheuvel wrote: > > On Mon, 7 Jun 2021 at 19:11, Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: > > > On Tue, Feb 09, 2021 at 05:51:45PM +0100, Ard Biesheuvel wrote: > > > > On Tue, 9 Feb 2021 at 17:45, Andy Shevchenko > > > > <andriy.shevchenko@linux.intel.com> wrote: > > > > > > > > > > When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather > > > > > its internal members. > > > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > > > > Acked-by: Ard Biesheuvel <ardb@kernel.org> > > > > > > Thanks! > > > > > > Can we get this applied, please? > > > > Apologies, this one slipped behind the desk. > > Do I need to resend it? > No, but I need an ack from James or Serge as it targets security/
On Thu, Aug 26, 2021 at 06:37:06PM +0200, Ard Biesheuvel wrote: > On Thu, 26 Aug 2021 at 17:08, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > On Thu, Jun 10, 2021 at 05:05:55PM +0200, Ard Biesheuvel wrote: > > > On Mon, 7 Jun 2021 at 19:11, Andy Shevchenko > > > <andriy.shevchenko@linux.intel.com> wrote: > > > > On Tue, Feb 09, 2021 at 05:51:45PM +0100, Ard Biesheuvel wrote: > > > > > On Tue, 9 Feb 2021 at 17:45, Andy Shevchenko > > > > > <andriy.shevchenko@linux.intel.com> wrote: > > > > > > > > > > > > When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather > > > > > > its internal members. > > > > > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > > > > > > Acked-by: Ard Biesheuvel <ardb@kernel.org> > > > > > > > > Thanks! > > > > > > > > Can we get this applied, please? > > > > > > Apologies, this one slipped behind the desk. > > > > Do I need to resend it? > > > > No, but I need an ack from James or Serge as it targets security/ It looks correct to me, based on Documentation/core-api/printk-formats.rst and existing examples. Reviewed-by: Serge Hallyn <serge@hallyn.com> thanks -serge
diff --git a/security/integrity/platform_certs/efi_parser.c b/security/integrity/platform_certs/efi_parser.c index 18f01f36fe6a..d98260f8402a 100644 --- a/security/integrity/platform_certs/efi_parser.c +++ b/security/integrity/platform_certs/efi_parser.c @@ -55,7 +55,7 @@ int __init parse_efi_signature_list( memcpy(&list, data, sizeof(list)); pr_devel("LIST[%04x] guid=%pUl ls=%x hs=%x ss=%x\n", offs, - list.signature_type.b, list.signature_list_size, + &list.signature_type, list.signature_list_size, list.signature_header_size, list.signature_size); lsize = list.signature_list_size;
When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather its internal members. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- security/integrity/platform_certs/efi_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)