diff mbox series

[3/9] dm: use fs_dax_get_by_bdev instead of dax_get_by_host

Message ID 20210826135510.6293-4-hch@lst.de (mailing list archive)
State Accepted
Commit dfa584f6f91586dbf7bb9f35f8bbdc06590cde1f
Headers show
Series [1/9] fsdax: improve the FS_DAX Kconfig description and help text | expand

Commit Message

Christoph Hellwig Aug. 26, 2021, 1:55 p.m. UTC 
There is no point in trying to finding the dax device if the DAX flag is
not set on the queue as none of the users of the device mapper exported
block devices could make use of the DAX capability.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
---
 drivers/md/dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dan Williams Aug. 26, 2021, 2:42 p.m. UTC | #1 
On Thu, Aug 26, 2021 at 6:59 AM Christoph Hellwig <hch@lst.de> wrote:
>
> There is no point in trying to finding the dax device if the DAX flag is
> not set on the queue as none of the users of the device mapper exported
> block devices could make use of the DAX capability.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  drivers/md/dm.c | 2 +-

Mike, any objections to me taking this through a dax branch?

>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/dm.c b/drivers/md/dm.c
> index 2c5f9e585211..465714341300 100644
> --- a/drivers/md/dm.c
> +++ b/drivers/md/dm.c
> @@ -650,7 +650,7 @@ static int open_table_device(struct table_device *td, dev_t dev,
>         }
>
>         td->dm_dev.bdev = bdev;
> -       td->dm_dev.dax_dev = dax_get_by_host(bdev->bd_disk->disk_name);
> +       td->dm_dev.dax_dev = fs_dax_get_by_bdev(bdev);
>         return 0;
>  }
>
> --
> 2.30.2
>
Mike Snitzer Aug. 26, 2021, 4:19 p.m. UTC | #2 
On Thu, Aug 26 2021 at 10:42P -0400,
Dan Williams <dan.j.williams@intel.com> wrote:

> On Thu, Aug 26, 2021 at 6:59 AM Christoph Hellwig <hch@lst.de> wrote:
> >
> > There is no point in trying to finding the dax device if the DAX flag is
> > not set on the queue as none of the users of the device mapper exported
> > block devices could make use of the DAX capability.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> > ---
> >  drivers/md/dm.c | 2 +-
> 
> Mike, any objections to me taking this through a dax branch?

No.

Reviewed-by: Mike Snitzer <snitzer@redhat.com>

Thanks.
diff mbox series

Patch

diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 2c5f9e585211..465714341300 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -650,7 +650,7 @@  static int open_table_device(struct table_device *td, dev_t dev,
 	}
 
 	td->dm_dev.bdev = bdev;
-	td->dm_dev.dax_dev = dax_get_by_host(bdev->bd_disk->disk_name);
+	td->dm_dev.dax_dev = fs_dax_get_by_bdev(bdev);
 	return 0;
 }