| Message ID | 20210907105913.15077-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | EDAC/device: Remove redundant initialization of pointer dev_ctl | expand |
On Tue, Sep 07, 2021 at 11:59:13AM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable dev_ctl is being initialized with a value that is never > read, it is being updated later on. The assignment is redundant and > can be removed. > > Addresses-Coverity: ("Unused value") I'll never get a public reference to what those things mean, will I? > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/edac/edac_device.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c > index 8c4d947fb848..a337f7afc3b9 100644 > --- a/drivers/edac/edac_device.c > +++ b/drivers/edac/edac_device.c > @@ -75,7 +75,6 @@ struct edac_device_ctl_info *edac_device_alloc_ctl_info( > * provide if we could simply hardcode everything into a single struct. > */ > p = NULL; > - dev_ctl = edac_align_ptr(&p, sizeof(*dev_ctl), 1); Are you absolutely sure this function doesn't have any side-effects, say, to &p and removing the call would break the pointer offsets for the one-shot allocation?
On 07/09/2021 12:11, Borislav Petkov wrote: > On Tue, Sep 07, 2021 at 11:59:13AM +0100, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> The variable dev_ctl is being initialized with a value that is never >> read, it is being updated later on. The assignment is redundant and >> can be removed. >> >> Addresses-Coverity: ("Unused value") > > I'll never get a public reference to what those things mean, will I? > >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- >> drivers/edac/edac_device.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c >> index 8c4d947fb848..a337f7afc3b9 100644 >> --- a/drivers/edac/edac_device.c >> +++ b/drivers/edac/edac_device.c >> @@ -75,7 +75,6 @@ struct edac_device_ctl_info *edac_device_alloc_ctl_info( >> * provide if we could simply hardcode everything into a single struct. >> */ >> p = NULL; >> - dev_ctl = edac_align_ptr(&p, sizeof(*dev_ctl), 1); > > Are you absolutely sure this function doesn't have any side-effects, > say, to &p and removing the call would break the pointer offsets for the > one-shot allocation? Oops. brown-paper-bag on head. It does alter p. NACK. >
On Tue, Sep 07, 2021 at 11:59:13AM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable dev_ctl is being initialized with a value that is never > read, it is being updated later on. The assignment is redundant and > can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/edac/edac_device.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c > index 8c4d947fb848..a337f7afc3b9 100644 > --- a/drivers/edac/edac_device.c > +++ b/drivers/edac/edac_device.c > @@ -75,7 +75,6 @@ struct edac_device_ctl_info *edac_device_alloc_ctl_info( > * provide if we could simply hardcode everything into a single struct. > */ > p = NULL; > - dev_ctl = edac_align_ptr(&p, sizeof(*dev_ctl), 1); ^^ This sets "p" up for the next call so I think it's required. regards, dan carpenter
diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c index 8c4d947fb848..a337f7afc3b9 100644 --- a/drivers/edac/edac_device.c +++ b/drivers/edac/edac_device.c @@ -75,7 +75,6 @@ struct edac_device_ctl_info *edac_device_alloc_ctl_info( * provide if we could simply hardcode everything into a single struct. */ p = NULL; - dev_ctl = edac_align_ptr(&p, sizeof(*dev_ctl), 1); /* Calc the 'end' offset past end of ONE ctl_info structure * which will become the start of the 'instance' array