| Message ID | 20210907121816.37750-6-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | nfc: minor printk cleanup | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 2 maintainers not CCed: wengjianfeng@yulong.com dan.carpenter@oracle.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | fail | Errors and warnings before: 374 this patch: 678 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 15 lines checked |
| netdev/build_allmodconfig_warn | fail | Errors and warnings before: 417 this patch: 500 |
| netdev/header_inline | success | Link |
On 07/09/2021 14:18, Krzysztof Kozlowski wrote: > ftrace is a preferred and standard way to debug entering and exiting > functions so drop useless debug prints. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > drivers/nfc/pn533/i2c.c | 1 - > drivers/nfc/pn533/pn533.c | 2 -- > 2 files changed, 3 deletions(-) > > diff --git a/drivers/nfc/pn533/i2c.c b/drivers/nfc/pn533/i2c.c > index e6bf8cfe3aa7..91d4a035eb63 100644 > --- a/drivers/nfc/pn533/i2c.c > +++ b/drivers/nfc/pn533/i2c.c > @@ -138,7 +138,6 @@ static irqreturn_t pn533_i2c_irq_thread_fn(int irq, void *data) > } > > client = phy->i2c_dev; This line should also be removed (reported by kbuild robot). I will send a v2. Best regards, Krzysztof
On Tue, 7 Sep 2021 18:05:25 +0200 Krzysztof Kozlowski wrote: > On 07/09/2021 14:18, Krzysztof Kozlowski wrote: > > ftrace is a preferred and standard way to debug entering and exiting > > functions so drop useless debug prints. > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > > --- > > drivers/nfc/pn533/i2c.c | 1 - > > drivers/nfc/pn533/pn533.c | 2 -- > > 2 files changed, 3 deletions(-) > > > > diff --git a/drivers/nfc/pn533/i2c.c b/drivers/nfc/pn533/i2c.c > > index e6bf8cfe3aa7..91d4a035eb63 100644 > > --- a/drivers/nfc/pn533/i2c.c > > +++ b/drivers/nfc/pn533/i2c.c > > @@ -138,7 +138,6 @@ static irqreturn_t pn533_i2c_irq_thread_fn(int irq, void *data) > > } > > > > client = phy->i2c_dev; > > This line should also be removed (reported by kbuild robot). > > I will send a v2. Dave marked the series as Deferred (although this patch is Changes Requested, I'm guessing you did that, if so please don't change patch states in netdev pw), please hold off: # Form letter - net-next is closed We have already sent the networking pull request for 5.15 and therefore net-next is closed for new drivers, features, code refactoring and optimizations. We are currently accepting bug fixes only. Please repost when net-next reopens after 5.15-rc1 is cut. Look out for the announcement on the mailing list or check: http://vger.kernel.org/~davem/net-next.html RFC patches sent for review only are obviously welcome at any time.
On 07/09/2021 19:03, Jakub Kicinski wrote: > On Tue, 7 Sep 2021 18:05:25 +0200 Krzysztof Kozlowski wrote: >> On 07/09/2021 14:18, Krzysztof Kozlowski wrote: >>> ftrace is a preferred and standard way to debug entering and exiting >>> functions so drop useless debug prints. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >>> --- >>> drivers/nfc/pn533/i2c.c | 1 - >>> drivers/nfc/pn533/pn533.c | 2 -- >>> 2 files changed, 3 deletions(-) >>> >>> diff --git a/drivers/nfc/pn533/i2c.c b/drivers/nfc/pn533/i2c.c >>> index e6bf8cfe3aa7..91d4a035eb63 100644 >>> --- a/drivers/nfc/pn533/i2c.c >>> +++ b/drivers/nfc/pn533/i2c.c >>> @@ -138,7 +138,6 @@ static irqreturn_t pn533_i2c_irq_thread_fn(int irq, void *data) >>> } >>> >>> client = phy->i2c_dev; >> >> This line should also be removed (reported by kbuild robot). >> >> I will send a v2. > > Dave marked the series as Deferred (although this patch is Changes > Requested, I'm guessing you did that, if so please don't change patch > states in netdev pw) Yes, that was me. Sorry for disturbing the process. >, please hold off: > > > # Form letter - net-next is closed > > We have already sent the networking pull request for 5.15 > and therefore net-next is closed for new drivers, features, > code refactoring and optimizations. We are currently accepting > bug fixes only. > > Please repost when net-next reopens after 5.15-rc1 is cut. > > Look out for the announcement on the mailing list or check: > http://vger.kernel.org/~davem/net-next.html > > RFC patches sent for review only are obviously welcome at any time. Sure, I'll wait till end of merge window. Best regards, Krzysztof
diff --git a/drivers/nfc/pn533/i2c.c b/drivers/nfc/pn533/i2c.c index e6bf8cfe3aa7..91d4a035eb63 100644 --- a/drivers/nfc/pn533/i2c.c +++ b/drivers/nfc/pn533/i2c.c @@ -138,7 +138,6 @@ static irqreturn_t pn533_i2c_irq_thread_fn(int irq, void *data) } client = phy->i2c_dev; - dev_dbg(&client->dev, "IRQ\n"); if (phy->hard_fault != 0) return IRQ_HANDLED; diff --git a/drivers/nfc/pn533/pn533.c b/drivers/nfc/pn533/pn533.c index 2f3f3fe9a0ba..c5f127fe2d45 100644 --- a/drivers/nfc/pn533/pn533.c +++ b/drivers/nfc/pn533/pn533.c @@ -1235,8 +1235,6 @@ static void pn533_listen_mode_timer(struct timer_list *t) { struct pn533 *dev = from_timer(dev, t, listen_timer); - dev_dbg(dev->dev, "Listen mode timeout\n"); - dev->cancel_listen = 1; pn533_poll_next_mod(dev);
ftrace is a preferred and standard way to debug entering and exiting functions so drop useless debug prints. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- drivers/nfc/pn533/i2c.c | 1 - drivers/nfc/pn533/pn533.c | 2 -- 2 files changed, 3 deletions(-)