| Message ID | 20210912160149.2227137-3-linux@roeck-us.net (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Introduce and use absolute_pointer macro | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 1 maintainers not CCed: arnd@arndb.de |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 2 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | warning | WARNING: line length of 106 exceeds 80 columns |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Sun, 12 Sep 2021 09:01:47 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > gcc 11.x reports the following compiler warning/error. > > drivers/net/ethernet/i825xx/82596.c: In function 'i82596_probe': > ./arch/m68k/include/asm/string.h:72:25: error: > '__builtin_memcpy' reading 6 bytes from a region of size 0 > [-Werror=stringop-overread] > > Use absolute_address() to work around the problem. => absolute_pointer() > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/net/ethernet/i825xx/82596.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/i825xx/82596.c > b/drivers/net/ethernet/i825xx/82596.c index > b8a40146b895..b482f6f633bd 100644 --- > a/drivers/net/ethernet/i825xx/82596.c +++ > b/drivers/net/ethernet/i825xx/82596.c @@ -1144,7 +1144,7 @@ static > struct net_device * __init i82596_probe(void) err = -ENODEV; > goto out; > } > - memcpy(eth_addr, (void *) 0xfffc1f2c, > ETH_ALEN); /* YUCK! Get addr from NOVRAM */ > + memcpy(eth_addr, absolute_pointer(0xfffc1f2c), > ETH_ALEN); /* YUCK! Get addr from NOVRAM */ dev->base_addr = > MVME_I596_BASE; dev->irq = (unsigned) MVME16x_IRQ_I596; > goto found; Regards, jer
On 9/12/21 9:11 AM, Jeroen Roovers wrote: > On Sun, 12 Sep 2021 09:01:47 -0700 > Guenter Roeck <linux@roeck-us.net> wrote: > >> gcc 11.x reports the following compiler warning/error. >> >> drivers/net/ethernet/i825xx/82596.c: In function 'i82596_probe': >> ./arch/m68k/include/asm/string.h:72:25: error: >> '__builtin_memcpy' reading 6 bytes from a region of size 0 >> [-Werror=stringop-overread] >> >> Use absolute_address() to work around the problem. > > => absolute_pointer() > Oopsie. Thanks! Guenter >> Cc: Geert Uytterhoeven <geert@linux-m68k.org> >> Signed-off-by: Guenter Roeck <linux@roeck-us.net> >> --- >> drivers/net/ethernet/i825xx/82596.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/i825xx/82596.c >> b/drivers/net/ethernet/i825xx/82596.c index >> b8a40146b895..b482f6f633bd 100644 --- >> a/drivers/net/ethernet/i825xx/82596.c +++ >> b/drivers/net/ethernet/i825xx/82596.c @@ -1144,7 +1144,7 @@ static >> struct net_device * __init i82596_probe(void) err = -ENODEV; >> goto out; >> } >> - memcpy(eth_addr, (void *) 0xfffc1f2c, >> ETH_ALEN); /* YUCK! Get addr from NOVRAM */ >> + memcpy(eth_addr, absolute_pointer(0xfffc1f2c), >> ETH_ALEN); /* YUCK! Get addr from NOVRAM */ dev->base_addr = >> MVME_I596_BASE; dev->irq = (unsigned) MVME16x_IRQ_I596; >> goto found; > > > Regards, > jer >
diff --git a/drivers/net/ethernet/i825xx/82596.c b/drivers/net/ethernet/i825xx/82596.c index b8a40146b895..b482f6f633bd 100644 --- a/drivers/net/ethernet/i825xx/82596.c +++ b/drivers/net/ethernet/i825xx/82596.c @@ -1144,7 +1144,7 @@ static struct net_device * __init i82596_probe(void) err = -ENODEV; goto out; } - memcpy(eth_addr, (void *) 0xfffc1f2c, ETH_ALEN); /* YUCK! Get addr from NOVRAM */ + memcpy(eth_addr, absolute_pointer(0xfffc1f2c), ETH_ALEN); /* YUCK! Get addr from NOVRAM */ dev->base_addr = MVME_I596_BASE; dev->irq = (unsigned) MVME16x_IRQ_I596; goto found;
gcc 11.x reports the following compiler warning/error. drivers/net/ethernet/i825xx/82596.c: In function 'i82596_probe': ./arch/m68k/include/asm/string.h:72:25: error: '__builtin_memcpy' reading 6 bytes from a region of size 0 [-Werror=stringop-overread] Use absolute_address() to work around the problem. Cc: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- drivers/net/ethernet/i825xx/82596.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)