| Message ID | 20210915081139.480263-1-saravanak@google.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | fw_devlink improvements | expand |
Hi Saravana, On 15.09.2021 10:11, Saravana Kannan wrote: > Patches ready for picking up: > Patch 1 fixes a bug in fw_devlink. > Patch 2-4 are meant to make debugging easier > Patch 5 and 6 fix fw_devlink issues with PHYs and networking Is this patchset supposed to fix the PHY related issues I've experienced or does it also require the Andrew's patch for 'mdio-parent-bus'? If the first, then applying only this patchset on top of today's linux-next doesn't fix the ethernet issue on my Amlogic SoC based test boards. > Andrew, > > I think Patch 5 and 6 should be picked up be Greg too. Let me know if > you disagree. > > -Saravana > > Cc: John Stultz <john.stultz@linaro.org> > Cc: Marek Szyprowski <m.szyprowski@samsung.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Vladimir Oltean <olteanv@gmail.com> > > v1->v2: > - Added a few Reviewed-by and Tested-by tags > - Addressed Geert's comments in patches 3 and 5 > - Dropped the fw_devlink.debug patch > - Added 2 more patches to the series to address other fw_devlink issues > > Thanks, > Saravana > > Saravana Kannan (6): > driver core: fw_devlink: Improve handling of cyclic dependencies > driver core: Set deferred probe reason when deferred by driver core > driver core: Create __fwnode_link_del() helper function > driver core: Add debug logs when fwnode links are added/deleted > driver core: fw_devlink: Add support for FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD > net: mdiobus: Set FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD for mdiobus parents > > drivers/base/core.c | 90 ++++++++++++++++++++++++++------------ > drivers/net/phy/mdio_bus.c | 4 ++ > include/linux/fwnode.h | 11 +++-- > 3 files changed, 75 insertions(+), 30 deletions(-) > Best regards
On Wed, Sep 15, 2021 at 01:11:32AM -0700, Saravana Kannan wrote: > Patches ready for picking up: > Patch 1 fixes a bug in fw_devlink. > Patch 2-4 are meant to make debugging easier > Patch 5 and 6 fix fw_devlink issues with PHYs and networking > > Andrew, > > I think Patch 5 and 6 should be picked up be Greg too. Let me know if > you disagree. > > -Saravana You are mixing fixes and development work. You should not do that, please keep them separate. They are heading in different directions. Fixed should get applied to -rc1, where as development work will be queued for the next merge window. You are also missing Fixes: tags for the two MDIO patches. Stable needs them to know how far back to port the fixes. Andrew
On Wed, Sep 15, 2021 at 1:44 AM Marek Szyprowski <m.szyprowski@samsung.com> wrote: > > Hi Saravana, > > On 15.09.2021 10:11, Saravana Kannan wrote: > > Patches ready for picking up: > > Patch 1 fixes a bug in fw_devlink. > > Patch 2-4 are meant to make debugging easier > > Patch 5 and 6 fix fw_devlink issues with PHYs and networking > > Is this patchset supposed to fix the PHY related issues I've experienced > or does it also require the Andrew's patch for 'mdio-parent-bus'? If the > first, then applying only this patchset on top of today's linux-next > doesn't fix the ethernet issue on my Amlogic SoC based test boards. Marek, The issue you hit was actually a general issue with fw_devlink and that's fixed by Patch 1. But I also needed to revert the phy-handle patch for other reasons (see commit text) and that fixes the issue you were hitting without needing the 'mdio-parent-bus' patch. https://lore.kernel.org/lkml/20210915081933.485112-1-saravanak@google.com/ When I eventually bring back phy-handle support, I'll need the 'mdio-parent-bus' to not break your use case. Hope that clarifies things. -Saravana > > > Andrew, > > > > I think Patch 5 and 6 should be picked up be Greg too. Let me know if > > you disagree. > > > > -Saravana > > > > Cc: John Stultz <john.stultz@linaro.org> > > Cc: Marek Szyprowski <m.szyprowski@samsung.com> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > > Cc: Andrew Lunn <andrew@lunn.ch> > > Cc: Vladimir Oltean <olteanv@gmail.com> > > > > v1->v2: > > - Added a few Reviewed-by and Tested-by tags > > - Addressed Geert's comments in patches 3 and 5 > > - Dropped the fw_devlink.debug patch > > - Added 2 more patches to the series to address other fw_devlink issues > > > > Thanks, > > Saravana > > > > Saravana Kannan (6): > > driver core: fw_devlink: Improve handling of cyclic dependencies > > driver core: Set deferred probe reason when deferred by driver core > > driver core: Create __fwnode_link_del() helper function > > driver core: Add debug logs when fwnode links are added/deleted > > driver core: fw_devlink: Add support for FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD > > net: mdiobus: Set FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD for mdiobus parents > > > > drivers/base/core.c | 90 ++++++++++++++++++++++++++------------ > > drivers/net/phy/mdio_bus.c | 4 ++ > > include/linux/fwnode.h | 11 +++-- > > 3 files changed, 75 insertions(+), 30 deletions(-) > > > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland >
On Wed, Sep 15, 2021 at 5:14 AM Andrew Lunn <andrew@lunn.ch> wrote: > > On Wed, Sep 15, 2021 at 01:11:32AM -0700, Saravana Kannan wrote: > > Patches ready for picking up: > > Patch 1 fixes a bug in fw_devlink. > > Patch 2-4 are meant to make debugging easier > > Patch 5 and 6 fix fw_devlink issues with PHYs and networking > > > > Andrew, > > > > I think Patch 5 and 6 should be picked up be Greg too. Let me know if > > you disagree. > > > > -Saravana > > You are mixing fixes and development work. You should not do that, > please keep them separate. They are heading in different > directions. Fixed should get applied to -rc1, where as development > work will be queued for the next merge window. Done. https://lore.kernel.org/lkml/20210915170940.617415-1-saravanak@google.com/ -Saravana -Saravana > > You are also missing Fixes: tags for the two MDIO patches. Stable > needs them to know how far back to port the fixes. > > Andrew
Hi, On 15.09.2021 18:44, Saravana Kannan wrote: > On Wed, Sep 15, 2021 at 1:44 AM Marek Szyprowski > <m.szyprowski@samsung.com> wrote: >> On 15.09.2021 10:11, Saravana Kannan wrote: >>> Patches ready for picking up: >>> Patch 1 fixes a bug in fw_devlink. >>> Patch 2-4 are meant to make debugging easier >>> Patch 5 and 6 fix fw_devlink issues with PHYs and networking >> Is this patchset supposed to fix the PHY related issues I've experienced >> or does it also require the Andrew's patch for 'mdio-parent-bus'? If the >> first, then applying only this patchset on top of today's linux-next >> doesn't fix the ethernet issue on my Amlogic SoC based test boards. > Marek, > > The issue you hit was actually a general issue with fw_devlink and > that's fixed by Patch 1. But I also needed to revert the phy-handle > patch for other reasons (see commit text) and that fixes the issue you > were hitting without needing the 'mdio-parent-bus' patch. > https://lore.kernel.org/lkml/20210915081933.485112-1-saravanak@google.com/ > > When I eventually bring back phy-handle support, I'll need the > 'mdio-parent-bus' to not break your use case. > > Hope that clarifies things. Okay, I missed the fact that you have sent the revert of the phy-handle patch. Now I see it in the linux-next, so everything is fine. Best regards