mbox series

[v11,0/4] multiple bssid and EMA support in AP mode

Message ID 20210715070745.5033-1-alokad@codeaurora.org (mailing list archive)
Headers show
Series multiple bssid and EMA support in AP mode | expand

Message

Aloka Dixit July 15, 2021, 7:07 a.m. UTC 
This patchset adds support for multiple BSSID and
enhanced multi-BSSID advertisements for AP mode.
Individual patches describe the changes in this version.

John Crispin (4):
  nl80211: MBSSID and EMA support in AP mode
  mac80211: MBSSID support in interface handling
  mac80211: MBSSID and EMA support in beacon handling
  mac80211: channel switch for non-transmitting interfaces

 include/net/cfg80211.h       |  44 ++++++
 include/net/mac80211.h       |  93 +++++++++++++
 include/uapi/linux/nl80211.h |  76 +++++++++-
 net/mac80211/cfg.c           | 170 +++++++++++++++++++++--
 net/mac80211/ieee80211_i.h   |   2 +
 net/mac80211/iface.c         |  29 +++-
 net/mac80211/tx.c            | 173 ++++++++++++++++++++---
 net/wireless/nl80211.c       | 261 +++++++++++++++++++++++++++++------
 8 files changed, 772 insertions(+), 76 deletions(-)


base-commit: 5e437416ff66981d8154687cfdf7de50b1d82bfc

Comments

Johannes Berg Aug. 17, 2021, 10:35 a.m. UTC | #1 
On Thu, 2021-07-15 at 00:07 -0700, Aloka Dixit wrote:
> This patchset adds support for multiple BSSID and
> enhanced multi-BSSID advertisements for AP mode.
> Individual patches describe the changes in this version.

How about adding the trivial advertisement to hwsim so we can have some
tests in hostapd?

johannes
Aloka Dixit Sept. 15, 2021, 3:47 a.m. UTC | #2 
On 2021-08-17 03:35, Johannes Berg wrote:
> On Thu, 2021-07-15 at 00:07 -0700, Aloka Dixit wrote:
>> This patchset adds support for multiple BSSID and
>> enhanced multi-BSSID advertisements for AP mode.
>> Individual patches describe the changes in this version.
> 
> How about adding the trivial advertisement to hwsim so we can have some
> tests in hostapd?
> 
> johannes

Hi Johannes,
Yes, I plan to add hwsim advertisement separately once kernel
changes are accepted. Will also add hostapd testcases at the
same time.
Thanks.
Johannes Berg Sept. 15, 2021, 10:47 a.m. UTC | #3 
On Tue, 2021-09-14 at 20:47 -0700, Aloka Dixit wrote:
> On 2021-08-17 03:35, Johannes Berg wrote:
> > On Thu, 2021-07-15 at 00:07 -0700, Aloka Dixit wrote:
> > > This patchset adds support for multiple BSSID and
> > > enhanced multi-BSSID advertisements for AP mode.
> > > Individual patches describe the changes in this version.
> > 
> > How about adding the trivial advertisement to hwsim so we can have some
> > tests in hostapd?
> > 
> > johannes
> 
> Hi Johannes,
> Yes, I plan to add hwsim advertisement separately once kernel
> changes are accepted. Will also add hostapd testcases at the
> same time.

OK, great! But adding it in hwsim is a kernel change, so why not just
send that patch together?

johannes
Aloka Dixit Sept. 15, 2021, 6:47 p.m. UTC | #4 
On 2021-09-15 03:47, Johannes Berg wrote:
> On Tue, 2021-09-14 at 20:47 -0700, Aloka Dixit wrote:
>> On 2021-08-17 03:35, Johannes Berg wrote:
>> > On Thu, 2021-07-15 at 00:07 -0700, Aloka Dixit wrote:
>> > > This patchset adds support for multiple BSSID and
>> > > enhanced multi-BSSID advertisements for AP mode.
>> > > Individual patches describe the changes in this version.
>> >
>> > How about adding the trivial advertisement to hwsim so we can have some
>> > tests in hostapd?
>> >
>> > johannes
>> 
>> Hi Johannes,
>> Yes, I plan to add hwsim advertisement separately once kernel
>> changes are accepted. Will also add hostapd testcases at the
>> same time.
> 
> OK, great! But adding it in hwsim is a kernel change, so why not just
> send that patch together?
> 
> johannes

Hi Johannes,

Trivial advertisement will not work because mac80211_hwsim_beacon_tx() 
does not handle the EMA case which may have more than one beacons 
transmitted.
It will need to be changed to use the newly added 
ieee80211_beacon_get_template().

Hence I will add a separate change for HWSIM.

Thanks.