| Message ID | 1631726561-16358-2-git-send-email-sandeen@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Remove DAX experimental warnings | expand |
On Wed, Sep 15, 2021 at 10:23 AM Eric Sandeen <sandeen@redhat.com> wrote: > > As there seems to be no significant outstanding concern about > dax on xfs at this point, remove the scary EXPERIMENTAL > warning when in use. > > (dax+reflink is still unimplemented, but that can be considered > a future feature, and doesn't require a warning for the > non-reflink usecase.) The original concern was that dax-reflink could not be implemented without ABI regressions. As far as I can see that concern has been put to rest by the proposed patches. Am I wrong? So, if we're committed to not breaking past promises I think this change can be made out-of-order from when the reflink support patches land. Acked-by: Dan Williams <dan.j.williams@intel.com> ...but I'm also fine with waiting for the final reflink merge.
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index c4e0cd1..0c71dbb 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -1594,9 +1594,6 @@ struct proc_xfs_info { if (xfs_has_dax_always(mp)) { bool rtdev_is_dax = false, datadev_is_dax; - xfs_warn(mp, - "DAX enabled. Warning: EXPERIMENTAL, use at your own risk"); - datadev_is_dax = xfs_buftarg_is_dax(sb, mp->m_ddev_targp); if (mp->m_rtdev_targp) rtdev_is_dax = xfs_buftarg_is_dax(sb,
As there seems to be no significant outstanding concern about dax on xfs at this point, remove the scary EXPERIMENTAL warning when in use. (dax+reflink is still unimplemented, but that can be considered a future feature, and doesn't require a warning for the non-reflink usecase.) Signed-off-by: Eric Sandeen <sandeen@redhat.com> --- fs/xfs/xfs_super.c | 3 --- 1 file changed, 3 deletions(-)