| Message ID | 20210916153056.13674-1-caihuoqing@baidu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Input: ad7879 - Make use of the helper function dev_err_probe() | expand |
On Thu, 16 Sept 2021 at 17:47, Cai Huoqing <caihuoqing@baidu.com> wrote: > > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> > --- > drivers/input/touchscreen/ad7879.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Please do not send patches one by one but group them in a series. The patches you sent were already sent before: https://lore.kernel.org/lkml/20200827185829.30096-1-krzk@kernel.org/ If such conversion is still applicable (although I have doubts - preferred is to remove dev_err entirely), then I can rebase my older series. Best regards, Krzysztof
diff --git a/drivers/input/touchscreen/ad7879.c b/drivers/input/touchscreen/ad7879.c index e850853328f1..440ebb3fc586 100644 --- a/drivers/input/touchscreen/ad7879.c +++ b/drivers/input/touchscreen/ad7879.c @@ -494,10 +494,9 @@ static int ad7879_parse_dt(struct device *dev, struct ad7879 *ts) u32 tmp; err = device_property_read_u32(dev, "adi,resistance-plate-x", &tmp); - if (err) { - dev_err(dev, "failed to get resistance-plate-x property\n"); - return err; - } + if (err) + return dev_err_probe(dev, err, + "failed to get resistance-plate-x property\n"); ts->x_plate_ohms = (u16)tmp; device_property_read_u8(dev, "adi,first-conversion-delay",
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> --- drivers/input/touchscreen/ad7879.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)