| Message ID | 20210920142713.129295-3-a-nandan@ti.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d7a48e27b38a94bf73c973c236461234610256d5 |
| Headers | show |
| Series | dt-bindings: mtd: spi-nand: Convert to DT schema | expand |
On Mon, Sep 20, 2021 at 07:57:13PM +0530, Apurva Nandan wrote: > Change the nodename in the example with spi-nand from 'spi-flash@1' > to 'flash@1' to make the schema uniform with both spi-nand and spi-nor > flashes. jedec,spi-nor.yaml uses 'flash@' nodename for spi-nor flashes, > so make the spi-nand examples in dt-bindings use it too for uniformity. > > Signed-off-by: Apurva Nandan <a-nandan@ti.com> > --- > Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Seems reasonable. Reviewed-by: Serge Semin <fancer.lancer@gmail.com> -Sergey > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > index ca91201a9926..d7e08b03e204 100644 > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > @@ -171,7 +171,7 @@ examples: > cs-gpios = <&gpio0 13 0>, > <&gpio0 14 0>; > rx-sample-delay-ns = <3>; > - spi-flash@1 { > + flash@1 { > compatible = "spi-nand"; > reg = <1>; > rx-sample-delay-ns = <7>; > -- > 2.25.1 >
On Mon, Sep 20, 2021 at 07:57:13PM +0530, Apurva Nandan wrote: > Change the nodename in the example with spi-nand from 'spi-flash@1' > to 'flash@1' to make the schema uniform with both spi-nand and spi-nor > flashes. jedec,spi-nor.yaml uses 'flash@' nodename for spi-nor flashes, > so make the spi-nand examples in dt-bindings use it too for uniformity. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
On Mon, 20 Sep 2021 19:57:13 +0530, Apurva Nandan wrote: > Change the nodename in the example with spi-nand from 'spi-flash@1' > to 'flash@1' to make the schema uniform with both spi-nand and spi-nor > flashes. jedec,spi-nor.yaml uses 'flash@' nodename for spi-nor flashes, > so make the spi-nand examples in dt-bindings use it too for uniformity. > > Signed-off-by: Apurva Nandan <a-nandan@ti.com> > --- > Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.example.dt.yaml:0:0: /example-0/spi@fff00000/flash@1: failed to match any schema with compatible: ['spi-nand'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1530168 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Mon, Sep 20, 2021 at 07:57:13PM +0530, Apurva Nandan wrote: > Change the nodename in the example with spi-nand from 'spi-flash@1' > to 'flash@1' to make the schema uniform with both spi-nand and spi-nor > flashes. jedec,spi-nor.yaml uses 'flash@' nodename for spi-nor flashes, > so make the spi-nand examples in dt-bindings use it too for uniformity. > > Signed-off-by: Apurva Nandan <a-nandan@ti.com> > --- > Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Fixes should come first. Maybe Mark can apply this before you respin. Acked-by: Rob Herring <robh@kernel.org> > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > index ca91201a9926..d7e08b03e204 100644 > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > @@ -171,7 +171,7 @@ examples: > cs-gpios = <&gpio0 13 0>, > <&gpio0 14 0>; > rx-sample-delay-ns = <3>; > - spi-flash@1 { > + flash@1 { > compatible = "spi-nand"; > reg = <1>; > rx-sample-delay-ns = <7>; > -- > 2.25.1 > >
On 21/09/21 2:49 am, Rob Herring wrote: > On Mon, Sep 20, 2021 at 07:57:13PM +0530, Apurva Nandan wrote: >> Change the nodename in the example with spi-nand from 'spi-flash@1' >> to 'flash@1' to make the schema uniform with both spi-nand and spi-nor >> flashes. jedec,spi-nor.yaml uses 'flash@' nodename for spi-nor flashes, >> so make the spi-nand examples in dt-bindings use it too for uniformity. >> >> Signed-off-by: Apurva Nandan <a-nandan@ti.com> >> --- >> Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > Fixes should come first. Maybe Mark can apply this before you respin. > > Acked-by: Rob Herring <robh@kernel.org> Please tell if I need to re-roll this series for changing the order of the two patches. >> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml >> index ca91201a9926..d7e08b03e204 100644 >> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml >> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml >> @@ -171,7 +171,7 @@ examples: >> cs-gpios = <&gpio0 13 0>, >> <&gpio0 14 0>; >> rx-sample-delay-ns = <3>; >> - spi-flash@1 { >> + flash@1 { >> compatible = "spi-nand"; >> reg = <1>; >> rx-sample-delay-ns = <7>; >> -- >> 2.25.1 >> >> Thanks, Apurva Nandan
diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml index ca91201a9926..d7e08b03e204 100644 --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml @@ -171,7 +171,7 @@ examples: cs-gpios = <&gpio0 13 0>, <&gpio0 14 0>; rx-sample-delay-ns = <3>; - spi-flash@1 { + flash@1 { compatible = "spi-nand"; reg = <1>; rx-sample-delay-ns = <7>;
Change the nodename in the example with spi-nand from 'spi-flash@1' to 'flash@1' to make the schema uniform with both spi-nand and spi-nor flashes. jedec,spi-nor.yaml uses 'flash@' nodename for spi-nor flashes, so make the spi-nand examples in dt-bindings use it too for uniformity. Signed-off-by: Apurva Nandan <a-nandan@ti.com> --- Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)