mbox series

[0/6] Get rid of pm_runtime_irq_safe() for 8250_omap

Message ID 20210921103346.64824-1-tony@atomide.com (mailing list archive)
Headers show
Series Get rid of pm_runtime_irq_safe() for 8250_omap | expand

Message

Tony Lindgren Sept. 21, 2021, 10:33 a.m. UTC
Hi,

Here are patches to get rid of pm_runtime_irq_safe() for the 8250_omap
driver.

For removing the pm_runtime_irq_safe() usage, serial TX is the last
remaining issue. We deal with TX by waking up the port and returning 0
bytes written from write_room() and write() if the port is not available
because of PM runtime autoidle.

This series also removes the dependency to Andy's pending generic serial
layer PM runtime patches, and hopefully makes that work a bit easier :)

Regards,

Tony


Tony Lindgren (6):
  n_tty: Start making use of -EAGAIN returned from
    process_output_block()
  tty: n_gsm: Don't ignore write return value in gsmld_output()
  serial: core: Add new prep_tx for power management
  serial: 8250: Implement prep_tx for power management
  serial: 8250_omap: Require a valid wakeirq for deeper idle states
  serial: 8250_omap: Drop the use of pm_runtime_irq_safe()

 Documentation/driver-api/serial/driver.rst |  9 ++++++
 drivers/tty/n_gsm.c                        |  5 ++-
 drivers/tty/n_tty.c                        |  8 +++--
 drivers/tty/serial/8250/8250_omap.c        | 36 +++++++++++++++-------
 drivers/tty/serial/8250/8250_port.c        | 24 +++++++++++++++
 drivers/tty/serial/serial_core.c           | 23 ++++++++++++++
 include/linux/serial_core.h                |  1 +
 7 files changed, 90 insertions(+), 16 deletions(-)

Comments

Andy Shevchenko Sept. 21, 2021, 12:03 p.m. UTC | #1
On Tue, Sep 21, 2021 at 1:34 PM Tony Lindgren <tony@atomide.com> wrote:
>
> Hi,
>
> Here are patches to get rid of pm_runtime_irq_safe() for the 8250_omap
> driver.
>
> For removing the pm_runtime_irq_safe() usage, serial TX is the last
> remaining issue. We deal with TX by waking up the port and returning 0
> bytes written from write_room() and write() if the port is not available
> because of PM runtime autoidle.

of the PM

>
> This series also removes the dependency to Andy's pending generic serial
> layer PM runtime patches, and hopefully makes that work a bit easier :)


Thank you, Tony, very much! The series looks to me in a good
condition, hence, FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Regards,
>
> Tony
>
>
> Tony Lindgren (6):
>   n_tty: Start making use of -EAGAIN returned from
>     process_output_block()
>   tty: n_gsm: Don't ignore write return value in gsmld_output()
>   serial: core: Add new prep_tx for power management
>   serial: 8250: Implement prep_tx for power management
>   serial: 8250_omap: Require a valid wakeirq for deeper idle states
>   serial: 8250_omap: Drop the use of pm_runtime_irq_safe()
>
>  Documentation/driver-api/serial/driver.rst |  9 ++++++
>  drivers/tty/n_gsm.c                        |  5 ++-
>  drivers/tty/n_tty.c                        |  8 +++--
>  drivers/tty/serial/8250/8250_omap.c        | 36 +++++++++++++++-------
>  drivers/tty/serial/8250/8250_port.c        | 24 +++++++++++++++
>  drivers/tty/serial/serial_core.c           | 23 ++++++++++++++
>  include/linux/serial_core.h                |  1 +
>  7 files changed, 90 insertions(+), 16 deletions(-)
>
> --
> 2.33.0