mbox series

[v2,0/3] scsi: remove last references to scsi_cmnd.tag

Message ID 1631696835-136198-1-git-send-email-john.garry@huawei.com (mailing list archive)
Headers show
Series scsi: remove last references to scsi_cmnd.tag | expand

Message

John Garry Sept. 15, 2021, 9:07 a.m. UTC
This is v2 of Hannes' series to fix the build errors from removing
scsi_cmnd.tag. Here is the original cover letter:

"with commit 4c7b6ea336c1 ("scsi: core: Remove scsi_cmnd.tag") drivers
cannot reference the SCSI command tag anymore.
Arguably these drivers would have stopped working since 2010 with
the switch to block layer tags in SCSI anyway, so chances are no-one
had been using tagging in these drivers.

This patchset fixes up these usage; for fas216 we're just switching
to use the appropriate wrapper.
For acornscsi the tagged queue handling is removed altogether as it
was broken in the first place, and no-one since the switch to git
could be bothered to fix it.
And the patchset has the nice side-effect that we can remove the
scsi_device.current_tag field."

AFAIK, only the arm rpc_defconfig build was broken.

I dropped the scsi_cmd_to_tag() patch as it was not strictly necessary here
and there was some doubt on its need.

The "scsi: remove 'current_tag'" patch is not needed as a fix.

Baseline is v5.15-rc1

Hannes Reinecke (3):
  fas216: kill scmd->tag
  acornscsi: remove tagged queuing vestiges
  scsi: remove 'current_tag'

 drivers/scsi/arm/Kconfig     |  11 ----
 drivers/scsi/arm/acornscsi.c | 103 ++++++++---------------------------
 drivers/scsi/arm/fas216.c    |  31 +++--------
 drivers/scsi/arm/queue.c     |   2 +-
 include/scsi/scsi_device.h   |   1 -
 5 files changed, 31 insertions(+), 117 deletions(-)

Comments

Martin K. Petersen Sept. 22, 2021, 4:44 a.m. UTC | #1
On Wed, 15 Sep 2021 17:07:12 +0800, John Garry wrote:

> This is v2 of Hannes' series to fix the build errors from removing
> scsi_cmnd.tag. Here is the original cover letter:
> 
> "with commit 4c7b6ea336c1 ("scsi: core: Remove scsi_cmnd.tag") drivers
> cannot reference the SCSI command tag anymore.
> Arguably these drivers would have stopped working since 2010 with
> the switch to block layer tags in SCSI anyway, so chances are no-one
> had been using tagging in these drivers.
> 
> [...]

Applied to 5.15/scsi-fixes, thanks!

[1/3] fas216: kill scmd->tag
      https://git.kernel.org/mkp/scsi/c/bc41fcbffd57
[2/3] acornscsi: remove tagged queuing vestiges
      https://git.kernel.org/mkp/scsi/c/756fb6a895af
[3/3] scsi: remove 'current_tag'
      https://git.kernel.org/mkp/scsi/c/a4869faf9642