[v2,0/2] Add Coresight support for RB5 board

Message

Tao Zhang Sept. 13, 2021, 6:40 a.m. UTC

This series adds Coresight support for SM8250 Soc on RB5 board.
It is composed of two elements.
a) Add ETM PID for Kryo-5XX.
b) Add coresight support to DTS for RB5.

This series applies to coresight/next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

Tao Zhang (2):
  coresight: etm4x: Add ETM PID for Kryo-5XX
  arm64: dts: qcom: sm8250: Add Coresight support

 arch/arm64/boot/dts/qcom/qrb5165-rb5.dts      | 442 +++++++++++++++++-
 .../coresight/coresight-etm4x-core.c          |   1 +
 2 files changed, 439 insertions(+), 4 deletions(-)

Comments

Suzuki K Poulose Sept. 21, 2021, 4:31 p.m. UTC | #1

Hi Tao

On 13/09/2021 07:40, Tao Zhang wrote:
> This series adds Coresight support for SM8250 Soc on RB5 board.
> It is composed of two elements.
> a) Add ETM PID for Kryo-5XX.
> b) Add coresight support to DTS for RB5.
> 
> This series applies to coresight/next
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> 

Please could you mention what has changed since the previous version
in the cover letter ?

Kind regards
Suzuki

> Tao Zhang (2):
>    coresight: etm4x: Add ETM PID for Kryo-5XX
>    arm64: dts: qcom: sm8250: Add Coresight support
> 
>   arch/arm64/boot/dts/qcom/qrb5165-rb5.dts      | 442 +++++++++++++++++-
>   .../coresight/coresight-etm4x-core.c          |   1 +
>   2 files changed, 439 insertions(+), 4 deletions(-)
>

Tao Zhang Sept. 23, 2021, 9:16 a.m. UTC | #2

On Tue, Sep 21, 2021 at 05:31:34PM +0100, Suzuki K Poulose wrote:
> Hi Tao
> 
> On 13/09/2021 07:40, Tao Zhang wrote:
> >This series adds Coresight support for SM8250 Soc on RB5 board.
> >It is composed of two elements.
> >a) Add ETM PID for Kryo-5XX.
> >b) Add coresight support to DTS for RB5.
> >
> >This series applies to coresight/next
> >https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> >
> 
> Please could you mention what has changed since the previous version
> in the cover letter ?
> 
> Kind regards
> Suzuki
>
The version 2 of the series add more comments "Cortex-A77" for ETM pid.
Do I need to rewrite the cover letter and then resubmit it for review?
> >Tao Zhang (2):
> >   coresight: etm4x: Add ETM PID for Kryo-5XX
> >   arm64: dts: qcom: sm8250: Add Coresight support
> >
> >  arch/arm64/boot/dts/qcom/qrb5165-rb5.dts      | 442 +++++++++++++++++-
> >  .../coresight/coresight-etm4x-core.c          |   1 +
> >  2 files changed, 439 insertions(+), 4 deletions(-)
> >
>

Suzuki K Poulose Sept. 23, 2021, 9:31 a.m. UTC | #3

On 23/09/2021 10:16, Tao Zhang wrote:
> On Tue, Sep 21, 2021 at 05:31:34PM +0100, Suzuki K Poulose wrote:
>> Hi Tao
>>
>> On 13/09/2021 07:40, Tao Zhang wrote:
>>> This series adds Coresight support for SM8250 Soc on RB5 board.
>>> It is composed of two elements.
>>> a) Add ETM PID for Kryo-5XX.
>>> b) Add coresight support to DTS for RB5.
>>>
>>> This series applies to coresight/next
>>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>>>
>>
>> Please could you mention what has changed since the previous version
>> in the cover letter ?
>>
>> Kind regards
>> Suzuki
>>
> The version 2 of the series add more comments "Cortex-A77" for ETM pid.
> Do I need to rewrite the cover letter and then resubmit it for review?

No need to resubmit the series for reveiwing the patch. Ultimately
patches are what matters. But it is a good practise to keep the
changelog in the cover letter for a revision of a series. That helps
the reviewers to understand what has changed and we all are able to
spend our time efficiently. So, please follow that if possible.

Thanks
Suzuki