Message ID | 20210831123637.22647-1-anthony.perard@citrix.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [XEN] Config.mk: update OVMF to edk2-stable202108 | expand |
On 31.08.2021 14:36, Anthony PERARD wrote: > Update to the latest stable tag. Largely out of curiosity - if that's truly a tag, ... > --- a/Config.mk > +++ b/Config.mk > @@ -244,7 +244,7 @@ QEMU_TRADITIONAL_URL ?= git://xenbits.xen.org/qemu-xen-traditional.git > SEABIOS_UPSTREAM_URL ?= git://xenbits.xen.org/seabios.git > MINIOS_UPSTREAM_URL ?= git://xenbits.xen.org/mini-os.git > endif > -OVMF_UPSTREAM_REVISION ?= b37cfdd2807181aed2fee1e17bd7ec1190db266a > +OVMF_UPSTREAM_REVISION ?= 7b4a99be8a39c12d3a7fc4b8db9f0eab4ac688d5 ... why not refer to it here and instead spell out a hash? Jan
On Tue, Aug 31, 2021 at 03:01:54PM +0200, Jan Beulich wrote: > On 31.08.2021 14:36, Anthony PERARD wrote: > > Update to the latest stable tag. > > Largely out of curiosity - if that's truly a tag, ... Well, it's a git tag, but it's not signed by upstream :-(. Upstream started to do a release for OVMF every 3 months somewhat recently. They will stop taking new feature and only take fixes for a couple of weeks, then tag the tree. > > --- a/Config.mk > > +++ b/Config.mk > > @@ -244,7 +244,7 @@ QEMU_TRADITIONAL_URL ?= git://xenbits.xen.org/qemu-xen-traditional.git > > SEABIOS_UPSTREAM_URL ?= git://xenbits.xen.org/seabios.git > > MINIOS_UPSTREAM_URL ?= git://xenbits.xen.org/mini-os.git > > endif > > -OVMF_UPSTREAM_REVISION ?= b37cfdd2807181aed2fee1e17bd7ec1190db266a > > +OVMF_UPSTREAM_REVISION ?= 7b4a99be8a39c12d3a7fc4b8db9f0eab4ac688d5 > > ... why not refer to it here and instead spell out a hash? Since the tag isn't signed, it's probably better to keep using a hash.
Anthony PERARD writes ("[XEN PATCH] Config.mk: update OVMF to edk2-stable202108"):
> Update to the latest stable tag.
Thanks. I am OK with this but I think we should hold off committing
it until the XSA fallout has been sorted.
Ian.
On Tue, Aug 31, 2021 at 02:58:36PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[XEN PATCH] Config.mk: update OVMF to edk2-stable202108"): > > Update to the latest stable tag. > > Thanks. I am OK with this but I think we should hold off committing > it until the XSA fallout has been sorted. Hopefully, this is sorted now. Time to commit the patch? Thanks,
Anthony PERARD writes ("Re: [XEN PATCH] Config.mk: update OVMF to edk2-stable202108"): > On Tue, Aug 31, 2021 at 02:58:36PM +0100, Ian Jackson wrote: > > Anthony PERARD writes ("[XEN PATCH] Config.mk: update OVMF to edk2-stable202108"): > > > Update to the latest stable tag. > > > > Thanks. I am OK with this but I think we should hold off committing > > it until the XSA fallout has been sorted. > > Hopefully, this is sorted now. Time to commit the patch? Well, things are still not good, but, yes, I have committed this. git seems to have auto-merged this successfully with the Mini-OS version update. Ian.
diff --git a/Config.mk b/Config.mk index 4d723eec1d0d..82b0c7c22743 100644 --- a/Config.mk +++ b/Config.mk @@ -244,7 +244,7 @@ QEMU_TRADITIONAL_URL ?= git://xenbits.xen.org/qemu-xen-traditional.git SEABIOS_UPSTREAM_URL ?= git://xenbits.xen.org/seabios.git MINIOS_UPSTREAM_URL ?= git://xenbits.xen.org/mini-os.git endif -OVMF_UPSTREAM_REVISION ?= b37cfdd2807181aed2fee1e17bd7ec1190db266a +OVMF_UPSTREAM_REVISION ?= 7b4a99be8a39c12d3a7fc4b8db9f0eab4ac688d5 QEMU_UPSTREAM_REVISION ?= master MINIOS_UPSTREAM_REVISION ?= 051b87bb9c19609976fb038f386920e1ce5454c5
Update to the latest stable tag. Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- Config.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)